[
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16634578#comment-16634578
]
ASF GitHub Bot commented on JENA-1609:
--------------------------------------
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/474#discussion_r221744935
--- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
@@ -39,17 +39,28 @@
<version>3.10.0-SNAPSHOT</version>
</dependency>
- <!-- Jena Driver configures Log4j directly -->
- <dependency>
- <groupId>org.slf4j</groupId>
- <artifactId>slf4j-log4j12</artifactId>
- </dependency>
+ <!-- Jena Driver configures Log4j directly -->
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-log4j12</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>log4j</groupId>
+ <artifactId>log4j</artifactId>
+ </dependency>
+
+ <dependency>
--- End diff --
IMO The fix is not to use log4 directly but to use SLF4J and LogCtl because
then logger can be swapped. But, for history reasons, this may not be
practical. cc @rvesse
> Jena master does not build under JDK10
> --------------------------------------
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
> Issue Type: Improvement
> Components: Build, Documentation
> Environment: Apache Maven 3.5.4
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
> Reporter: Lewis John McGibbney
> Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause
> the build to fail. The following PR addresses these issues and enables me to
> build and run Jena master under JDK 10.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
