Github user afs commented on the issue:

    https://github.com/apache/jena/pull/491
  
    Looking at other recent PRs, it looks like they are pulled from your BDRC 
repo then close the PR. This is why they are "closed", not "merged".
    
    The documented workflow is to merge from the github PR - it is not 
proscriptive and if your way works for you, then fine. It's the same commits 
(same SHA1), different route.
    
    Normally I do:
    
    git pull github pull/NNN/head --no-ff
    git push
    
    as in your modified "11.". Then when the GH repo sync's up with Apache 
master (a few minutes at most), the PR here goes purple/merged and has a 
"delete branch" option to delete the branch in your repo that you created the 
PR from.
    
    The "This closes \#NNN" text does not have to be in the first line of the 
commit message. 
    
    If convenient, could you put "JENA-nnnn:" on the front of important commits 
or the merge commit message? Don't matter if you don't, just makes things a but 
more findable from just git logs in my experience.



---

Reply via email to