Turned into JIRA and a PR.
Andy
On 08/03/2019 22:37, Bruno P. Kinoshita wrote:
I don't mind the changes, but haven't had to chase many bugs using our git
history.
:-)
The code looks more concise with the latest code added to the project. So my +1
Cheers
Bruno
On Saturday, 9 March 2019, 6:37:07 am NZDT, Andy Seaborne <[email protected]>
wrote:
The git history is useful in finding when bugs appeared and the lineage
of a feature. That's the main reason a mass reformatting of code for
whitespace or style has a significant impact - it obscures the history
and some history is very long (we have back to the beginning of SVN, but
not CVS).
Packages jena-db/jena-dboe-* packages, and maybe jena-db/jena-tdb2, are
sufficiently new and their history short that it would not be too
disruptive.
There is a window of opportunity to clean up these packages.
See below for some transformations of the source.
Thoughts/comments?
Andy
https://github.com/apache/jena/compare/master...afs:code-clean
results in:
214 files changed, 11254 insertions(+), 11676 deletions(-)
Proposed cleanup is these two perl scripts:
# Clean trailing whitespace.
# Replace "space semi-colon" with "semi-colon".
perl -i -p \
-e 's/ +$//;' \
-e 's/ ;/;/' \
"$@"
and the "perl -i" script:
# Convert to staggered opening braces
# Replace "newline { newline" with " { newline"
# - needs a few post-convert fixups.
# Turn double or more blank lines to single.
undef $/;
$_=<>;
s/\n +{\n/ {\n/g ;
s/\n\n\n/\n\n/g;
print $_;
