afs commented on issue #557: JENA-664 GeoSPARQL Jena URL: https://github.com/apache/jena/pull/557#issuecomment-487297031 ## Status (2019-04-27) ### Next I've made some changes locally and got the build to work with tests. All the changes are detailed below. If the changes are OK, I can merge the PR and apply them. There is still some possible clearing up but the only necessary step before release is the L&N for the shared Fuseki server. ### Details The parent POM has some stray formatting. #### Module: jena-geosparql Some line ends need fixing - they are windows style (when using a diff, this shows up). Surefire plugin configuration is for another way to run tests but for this module runs no tests. The automatic test determination works fine for jena-geosparql. Delete output in tests such as "System.out.println" and companion "//System.out.println". Add dependencies: ``` <!-- Non-free; testing only --> <dependency> <groupId>org.apache.sis.non-free</groupId> <artifactId>sis-embedded-data</artifactId> <version>0.8</version> <scope>runtime</scope> </dependency> <dependency> <groupId>javax.xml.bind</groupId> <artifactId>jaxb-api</artifactId> <version>2.3.1</version> </dependency> ``` Then mvn8 clean test -Drat.skip=true passes. (mvn8 is my script to run mvn with OpenJDK 8) #### RAT Legal Check Add to the parent POM: <exclude>**/geosparql_vocab_all_v1_0_1_updated.rdf</exclude> Delete logback*.xml then mvn8 clean test passes. #### Java11 maven with OpenJDK11 : has problems which look like a precison/length change somewhere in the depths. `BufferFFTest` does some comparison of quite large objects, too big to describe here. There are some tests on `LatLonPoint` like: GreatCirclePointDistanceTest.testGetPoint_3args_East:185 expected: <LatLonPoint{lat=48.84533344929755, lon=-0.9821733277296272}> but was: <LatLonPoint{lat=48.845333449297556, lon=-0.982173327729628}> The test uses `assertEquals(Object,Object)`, no precision factor considered as is available with `assertEquals(double, double, delta)`. Something for later. #### Module jena-fuseki-geosparql Worked first time! There will be a bit of L&N work for `geosparql_vocab_all_v1_0_1_updated.rdf`. I think it would be better placed as: /jena-fuseki2/jena-fuseki-geosparql but still run from the top POM (not in jena-fuseki2/pom.xml for now). A better Java package name would be to put in the Fuseki family: `package org.apache.jena.jena_fuseki_geosparql` ==> `package org.apache.jena.fuseki.geosparql`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
