[
https://issues.apache.org/jira/browse/JENA-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477920#comment-17477920
]
Andy Seaborne commented on JENA-2254:
-------------------------------------
DatasetSetupOperation.setup Line 75 in jena-fuseki-geosparql does not touch the
return.
convertGeoPredicates(Model model) creates a fresh model.
d1 is untouched.
d2 is returned but dropped by the caller.
It's not wrapping:
{noformat}
Dataset outputDataset = DatasetFactory.createTxnMem();
outputDataset.begin(ReadWrite.WRITE);
dataset.begin(ReadWrite.READ);
{noformat}
{{outputDataset.addNamedModel}} and {{outputDataset.setDefaultModel}} are "copy
into" operations.
> Custom long/lat spatial predicate pairs for geosparql
> -----------------------------------------------------
>
> Key: JENA-2254
> URL: https://issues.apache.org/jira/browse/JENA-2254
> Project: Apache Jena
> Issue Type: New Feature
> Components: GeoSPARQL
> Reporter: Øyvind Gjesdal
> Priority: Minor
>
> At the moment geosparql supports many of the old jena-spatial functions.
> The jena-spatial module also had custom long/lat and also custom WKT
> predicates. At the moment we still use the old jena spatial module, but when
> the assembler file for geosparql is ready in jena 4.4, I think we can switch.
> Writing an assembler which uses both jena-text and geosparql is how we've
> mostly used the jena-spatial module.
> One remaining issue we have in our data (from external datasets), is custom
> long/lat predicates. Bringing support for these would be nice. I tried to
> look at the code, and it seems the geo:long,geo:lat are translated in
> https://github.com/apache/jena/blob/main/jena-geosparql/src/main/java/org/apache/jena/geosparql/configuration/GeoSPARQLOperations.java#L749
> Would it work/be enough to look up/reuse the jena-spatial assembler
> predicates, and also loop through these pairs in the
> *convertGeoPredicates(Dataset dataset, boolean isRemoveGeoPredicate)* or
> should there be a new method to convert custom predicates?
> This is how the old assembler looks, from the jena-site:
>
> {code:java}
> # custom geo predicates for 1) Latitude/Longitude Format
> spatial:hasSpatialPredicatePairs (
> [ spatial:latitude :latitude_1 ; spatial:longitude :longitude_1 ]
> [ spatial:latitude :latitude_2 ; spatial:longitude :longitude_2 ]
> ) ; {code}
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
