[GitHub] [jena-site] kinow commented on pull request #144: Create an automatic Table of Contents, position it as a sidebar (large screen) or at the top of page (smaller than large screen)

[via GitHub]

kinow commented on PR #144:
URL: https://github.com/apache/jena-site/pull/144#issuecomment-1426857323

   Hi @afs, not a problem! I imagined you'd be busy but wanted to ask your 
review as I remember during the port to Hugo you worked on the existing table 
of contents, and might have some feedback.
   
   >I tries it out quickly and it looks good. Some pages need further 
refinement because they have a TOC for the area (e.g. 
http://localhost:1313/documentation/io/).
   
   Ah, good catch. So that page has internal and external links. Instead of 
deleting everything, I removed the local ones (to give users a single behavior 
for internal links, i.e. use the ToC at the sidebar or top menu if mobile) but 
left the external links as a suggestion. Here's a screenshot of what I did:
   
   
![image](https://user-images.githubusercontent.com/304786/218276812-e5338d8a-c178-49f7-b4ca-9ac4d4418a1a.png)
   
   I started going through the entries in the top menu, and found in the Fuseki 
page a mix of internal and external links that seems to be intentionally 
organized for users to follow.
   
   
![image](https://user-images.githubusercontent.com/304786/218276919-d23ab55f-9674-4d9b-8e2a-ae5a32c14431.png)
   
   Removing the internal links and leaving the rest wouldn't be really helpful, 
I think. Let me think about this one before merging or doing any other changes…
   
   Thanks for the review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jena.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org