On 30 November 2011 22:16, <[email protected]> wrote: > Author: pmouawad > Date: Wed Nov 30 22:16:35 2011 > New Revision: 1208836 > > URL: http://svn.apache.org/viewvc?rev=1208836&view=rev > Log: > Made code cleaner
Perhaps, but it introduces a subtle bug, see below. > Modified: > jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java > > Modified: > jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java > URL: > http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java?rev=1208836&r1=1208835&r2=1208836&view=diff > ============================================================================== > --- jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java > (original) > +++ jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java > Wed Nov 30 22:16:35 2011 > @@ -389,10 +389,10 @@ public class ResultCollector extends Abs > // Find the name of the directory containing the file > // and create it - if there is one > File pdir = new File(filename).getParentFile(); > - if (pdir != null) { > - pdir.mkdirs();// returns false if directory already exists, > so need to check again > - if (!pdir.exists()){ > - log.warn("Error creating directories for > "+pdir.toString()); > + if (pdir != null && !pdir.exists()) { > + boolean mkdirResult = pdir.mkdirs(); > + if (!mkdirResult){ It's not totally safe to check the return from mkdirs() after checking exists(). See for example: https://issues.apache.org/jira/browse/JCI-67 Please revert the change. > + log.warn("Error creating directories for > "+pdir.getAbsolutePath()); > } > } > writer = new PrintWriter(new OutputStreamWriter(new > BufferedOutputStream(new FileOutputStream(filename, > >
