On 20 January 2012 06:25, Philippe Mouawad <philippe.moua...@gmail.com> wrote: > Hello, > I don't agree. > Tests on loadAndSave seems wrong to me as it does not take into account > upgrade procedure . > Furthermore I don't understand the purpose of TestGUI23.jmx, from what I > supposed it was to test 2.3 format but > If I upgrade the format what's the use of the Test case ?
As I already wrote, at least it checks the other test elements. Maybe there needs to be another test which specifically checks upgrades, but I don't think the test is useless. If there is another such test, then elements could be moved to it when they are upgraded. > Regards > Philippe > > On Fri, Jan 20, 2012 at 1:35 AM, sebb <seb...@gmail.com> wrote: > >> On 19 January 2012 22:38, <pmoua...@apache.org> wrote: >> > Author: pmouawad >> > Date: Thu Jan 19 22:38:44 2012 >> > New Revision: 1233614 >> > >> > URL: http://svn.apache.org/viewvc?rev=1233614&view=rev >> > Log: >> > Commenting test to avoid failure. >> > TestLoadAndSave seems wrong as it does not take into account migration. >> >> -1 >> >> I don't think that's the correct fix. >> It would be better to update the test file to the new settings. >> Otherwise, other (incorrect) changes to JMeter might be missed. >> >> > Modified: >> > jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java >> > >> > Modified: >> jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java >> > URL: >> http://svn.apache.org/viewvc/jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java?rev=1233614&r1=1233613&r2=1233614&view=diff >> > >> ============================================================================== >> > --- jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java >> (original) >> > +++ jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java >> Thu Jan 19 22:38:44 2012 >> > @@ -43,7 +43,7 @@ public class TestSaveService extends JMe >> > "ProxyServerTestPlan.jmx", >> > "SimpleTestPlan.jmx", >> > "GuiTest.jmx", >> > - "GuiTest231.jmx", >> > + //"GuiTest231.jmx", Commenting as testLoadAndSave will fails >> > }; >> > >> > private static final boolean saveOut = >> JMeterUtils.getPropDefault("testsaveservice.saveout", false); >> > >> > >> > > > > -- > Cordialement. > Philippe Mouawad.
