Hello sebb, I attached patch. Regards Philippe
On Tue, Jul 2, 2013 at 1:21 AM, sebb <[email protected]> wrote: > On 1 July 2013 16:18, Philippe Mouawad <[email protected]> wrote: > > Created bug: > > https://issues.apache.org/bugzilla/show_bug.cgi?id=55175 > > > > Waiting for your feedback before commit. > > We'll need a bit more detail. > What exactly are you proposing? > > Note that making a method protected usually means freezing its API, so > the API had better be correct before doing so. > > However, if the inheritance is intended only for use by JMeter code - > and is clear;y documented as such - then the API could be changed if > necessary. > > If it is for use by 3rd party plugins, then the API design needs a lot > of care to ensure it does not restrict future development. > > > On Mon, Jul 1, 2013 at 5:06 PM, Philippe Mouawad < > [email protected] > >> wrote: > > > >> Hello, > >> As per sebb request, I ask before implementing :-) > >> > >> I would like to refactor slightly HTTPHC4Impl to allow inheritance from > it > >> to reuse many of already implemented and useful internals. > >> This would be useful to classes that which for example to post binary > >> content and similar stuff. > >> > >> Are you ok with it ? Can I open a bugzilla and do it ? > >> > >> Thanks > >> -- > >> Regards. > >> Philippe. > >> > >> > >> > > > > > > -- > > Cordialement. > > Philippe Mouawad. > -- Cordialement. Philippe Mouawad.
