I understood javadoc differently, your explanation makes sense, unfortunately for now I don't have other ideas.
On Wednesday, August 21, 2013, sebb wrote: > On 20 August 2013 22:53, Philippe Mouawad > <[email protected]<javascript:;>> > wrote: > > I think I have fixed it, please review to double check. > > The combo.getSelectedItem() Javadoc comment says: > > "If the combo box is editable, then this value may not have been added > to the combo box with addItem, insertItemAt or the data constructors." > > I read that as meaning that the value may have come from the user; > i.e. it is not text put there by the program. > Note that it says "this value" - to me that means "the value that is > returned from combo.getSelectedItem()" > > The patch does work, but I assume that is because the editor has the > original copy of the text. > So it makes up for the fact that the text has not been propagated to > the combo box field yet. > > But why is the editted text not being pushed to the combo box? > Is it being pushed AFTER the data has been saved to the test element, > which therefore sees the old value? > > Although this patch fixes the combo box issue, I think it fixes the > symptom, not the underlying cause. > Which means that there could be other GUI fields that are not behaving > correctly. > So I don't think it should be regarded as more than a work-round. > > > Thanks > > > > > > On Tue, Aug 20, 2013 at 11:08 PM, sebb <[email protected]> wrote: > > > >> On 20 August 2013 21:16, Philippe Mouawad <[email protected]> > >> wrote: > >> > Regarding the bug, there is something I don't clearly understand in > >> > PropertyEditorSupport subclass , why does FieldStringEditor implement > >> > FocusListener and not ComboStringEditor ? > >> > > >> > Do you know why ? > >> > >> Sorry, no. > >> > >> > > >> > On Tue, Aug 20, 2013 at 5:12 PM, sebb <[email protected]> wrote: > >> > > >> >> On 20 August 2013 13:11, Philippe Mouawad < > >> [email protected]> > >> >> wrote: > >> >> > Hello Sebb, > >> >> > I don't think you broke it, I made some checks and it seems it is > >> broken > >> >> in > >> >> > versions before your change. > >> >> > >> >> OK, however I think I did do some damage to ComboStringEditor when I > >> >> changed the static EDIT and UNDEFINED fields to instance variables - > >> >> the code relied on '==' comparisons which won't work with instance > >> >> variables. I'll fix that shortly. > >> >> > >> >> > Could be related to: > >> >> > https://issues.apache.org/bugzilla/show_bug.cgi?id=55103 > >> >> > >> >> Yes, looks quite likely. > >> >> > >> >> > Regards > >> >> > > >> >> > > >> >> > On Tue, Aug 20, 2013 at 12:10 AM, <[email protected]> wrote: > >> >> > > >> >> >> https://issues.apache.org/bugzilla/show_bug.cgi?id=55432 > >> >> >> > >> >> >> Sebb <[email protected]> changed: > >> >> >> > >> >> >> What |Removed |Added > >> >> >> > >> >> >> > >> >> > >> > ---------------------------------------------------------------------------- > >> >> >> Status|REOPENED |RESOLVED > >> >> >> Resolution|--- |FIXED > >> >> >> > >> >> >> --- Comment #5 from Sebb <[email protected]> --- > >> >> >> It's not just CSV Dataset - JSR223 Preproces has the same issue. > >> >> >> > >> >> >> Looks like I broke ComboStringEditor while implementing Bug 55440 > >> >> >> > >> >> >> I'll close this and re-open that. > >> >> >> > >> >> >> -- > >> >> >> You are receiving this mail because: > >> >> >> You are on the CC list for the bug. > >> >> >> You are watching the reporter of the bug. > >> >> >> > >> >> > > >> >> > > >> >> > > >> >> > -- > >> >> > Cordialement. > >> >> > Philippe Mouawad. > >> >> > Ubik-Ingénierie > >> >> > > >> >> > UBIK LOAD PACK Web Site <http://www.ubikloadpack.com/> > >> >> > > >> >> > UBIK LOAD PACK on TWITTER <https://twitter.com/ubikloadpack> > >> >> > >> > > >> > > > -- Cordialement. Philippe Mouawad.
