On 17.10.2013 16:40, Milamber wrote:

> All feedback (and votes!) welcome.
>     
> [XX] +1  I support this release
> [  ] +0  I am OK with this release
> [  ] -0   OK, but....
> [  ] -1   I do not support this release (please indicate why)

+1 (binding), thanks for RM!

Details:

- MD5 OK
- signatures OK
- key in KEYS file

- gz and zip for src and bin consistent, except
  directory licenses/bin is only part of svn and the
  gz and zip bin distributions, but not part of
  the src distribution. So a bin distribution regenerated
  from the src distribution does not contain the files.
  Not a show-stopper IMHO.

- builds fine

- build result looks consistent with distribution, except for
  - timestamps in generated javadoc (expected)
  - binary jar files (expected)

- no Javadoc warnings

- ran the tests (but only with java.awt.headless)

- I have not checked the staging repository.

Build and tests were done using Java 1.6.0_45, OS was Solaris 10 Sparc.

Regards,

Rainer

Reply via email to