On 24 October 2013 20:46, Philippe Mouawad <[email protected]> wrote:
The JAVA_HOME variable is not actually needed. However Java _must_ be on the PATH otherwise JMeter itself won't start. So I don't understand why there are problems, unless the PATH points to a Java installation that does not include keytool. Clearly the code needs to be better at detecting whether keytool is present on the path or not. I'm less keen on providing a property which points to keytool. If the user installed a new version of Java or moved it the property would need to be changed. Though I suppose we could log an error if the property is defined incorrectly. As to documentation, the easiest might be to start with a Wiki page that can later be copied to the website. > I suggest adding this to pdf jmeter_proxy_step_by_step.pdf: > In Basic Instructions: > > 1. > > Set JAVA_HOME environment variable to point to a JDK 6 or 7, JDK7 is > preferred for recording: > 1. > > Linux/Unix, add in jmeter file : > > > - > > JAVA_HOME=<PATH TO JDK> > - > > export JAVA_HOME > > > 1. > > Windows, add in jmeter.bat file: > > > - > > set JAVA_HOME=<PATH TO JDK> > > > 1. > > Add java bin folder to PATH environment variable : > 1. > > Linux, add in jmeter file : > > > - > > PATH=$PATH;$JAVA_HOME/bin > - > > export PATH > > > 1. > > Windows, add in jmeter.bat file: > > > - > > set PATH=%PATH%;%JAVA_HOME%\bin > > > > > Maybe we should also add a new property in jmeter.properties: > proxy.cert.keytool.path=<path to keytool> > > This would avoid the above configuration. > > Thoughts ? > > > On Thu, Oct 24, 2013 at 7:34 PM, Milamber <[email protected]> wrote: > >> >> Le 24/10/2013 17:34, Philippe Mouawad a ecrit : >> >> Hello, >>> I answered the SO question: >>> - >>> http://stackoverflow.com/**questions/19550472/jmeter-** >>> recorder-throws-keytool-**exception<http://stackoverflow.com/questions/19550472/jmeter-recorder-throws-keytool-exception> >>> >>> The person who asked accepted it, but another guy is also facing the >>> issue. >>> It could be an issue faced by many newbies. >>> >>> I think we should at least update LIVE docs if you agree with answer. >>> >>> Do you think we should release a 2.10.1 to fix it or make it easier ? >>> >> >> >> Perhaps it's a good idea to release rapidly a new JMeter version (minor >> 2.10.1 or directly 2.11). The OS sampler timeout bug is very annoying too. >> >> >> >> >> >>> Regards >>> Philippe >>> >>> >>> On Thu, Oct 24, 2013 at 8:21 AM, Philippe Mouawad < >>> [email protected]> wrote: >>> >>> Hello, >>>> It seems isse with keytool command line not being available is happening >>>> to users: >>>> >>>> - >>>> http://stackoverflow.com/**questions/19550472/jmeter-** >>>> recorder-throws-keytool-**exception<http://stackoverflow.com/questions/19550472/jmeter-recorder-throws-keytool-exception> >>>> >>>> I think we should very rapidly : >>>> - document the full setup ( I don't have windows machine to reproduce it) >>>> for this kind of issues because it affects recording and could be felt >>>> as a >>>> regression . And update online docs. >>>> - answer this question at stackoverflow >>>> >>>> Regards >>>> Philippe >>>> >>>> On Tuesday, October 22, 2013, sebb wrote: >>>> >>>> On 22 October 2013 14:48, Milamber <[email protected]> wrote: >>>>> >>>>>> Le 22/10/2013 12:02, sebb a ecrit : >>>>>> >>>>>> If running under Java 7, the Test Recorder always tries to create a >>>>>>> certificate file when starting the Proxy. That was possibly a mistake, >>>>>>> but the intention was to ensure that the certificate was available >>>>>>> before recording started. >>>>>>> >>>>>>> The consequence is that the cert is created even if the user is not >>>>>>> recording HTTPS. This can cause problems if the Java installation does >>>>>>> not include keytool, or if the bin directory is not writable. Also it >>>>>>> slows down the start. >>>>>>> >>>>>>> So maybe there should be an option on the Recorder screen which >>>>>>> specifies whether or not the user wants to record HTTPS? >>>>>>> >>>>>> >>>>>> Yes and no. Today the website pages mix http and https urls, and it's >>>>>> difficult to the user to find all url before the record session to >>>>>> >>>>> check if >>>>> >>>>>> https exists. >>>>>> >>>>> In which case there's no point trying to avoid creation of the >>>>> certificate. >>>>> >>>>> Perhaps, start Recorder without https support, and if a https url is >>>>>> detected, then display a message (pop-up in JMeter or a log message) >>>>>> >>>>> I don't think that would work. There's no guarantee that the user will >>>>> see the pop-up if they are busy using the browser for recording. >>>>> >>>>> Add a new checkbox "Don't display message when a https url is detected" >>>>>> >>>>> I assume that relates to the suggestion to add a pop-up. >>>>> >>>>> >>>>>> For example, I did wonder if the new HTTPS domain field should be used >>>>>>> for that purpose (i.e. check if it is non-empty). Or do we need a >>>>>>> separate checkbox? >>>>>>> >>>>>>> It does look as though the code should check to see if keytool is >>>>>>> available, and revert to the original behaviour if not. >>>>>>> >>>>>> Yes to check if keytool is available in all case. >>>>>> The original behavior is the 2.9 behavior (jmeterserver.jks with fake >>>>>> >>>>> ssl >>>>> >>>>>> cert provide in binary archive)? >>>>>> >>>>> There is no longer any SSL certificate provided with JMeter. >>>>> Either the user must create their own, or they must use a Java >>>>> installation that supports keytool. >>>>> [Or we need to work out how to use BouncyCastle to create the certs.] >>>>> >>>>> Also maybe >>>>>>> check if the target directory is writable. >>>>>>> >>>>>> >>>>>> Yes must be done in all case. >>>>>> >>>>>> >>>> -- >>>> Cordialement. >>>> Philippe Mouawad. >>>> >>>> >>>> >>>> >>>> >>> >> > > > -- > Cordialement. > Philippe Mouawad.
