On 22 December 2013 23:06, Philippe Mouawad <[email protected]> wrote: > Hello, > Looking at StatisticalSamplerSender, I don't understand how this > SamplerSender works. > > It seems to me it can work correctly only if numSamplesThreshold is equal > to 1. > > And according to: > - https://issues.apache.org/bugzilla/show_bug.cgi?id=48889 > - https://issues.apache.org/bugzilla/show_bug.cgi?id=54478 > > It seems it is the case , although 48889 is supposed to have been fixed but > maybe some hypothesis was broken afterwards. > > Does any of you know how it is supposed to work ? > > I would have thought this samplersender would compute some averages but > reading the code it does not seem to be the case. > > If you confirm my doubts, I suggest we add a note saying not to use it > until we fix it and warn if numSamplesThreshold != 1
Probably a good idea to add a unit test for it, e.g. along the lines of the existing batch tests. > > Regards > Philippe
