Hello Sebb, As requested although I don't see why it cannot be in bugzilla,if it were the history of discussion could be found more easily.
Regards Philippe On Fri, Jan 3, 2014 at 1:57 PM, <bugzi...@apache.org> wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=55932 > > --- Comment #6 from Sebb <s...@apache.org> --- > I have been having a look at the implementation. > > I don't really see that it needs Commons Math; we aleady have > StatCalculator > which handles percentiles and more. > Ok I can change this. > > Likewise, does it really need Commons Pool? > It seems wrong to have to have 2 separate pools of SocketOutputStream > instances. > Can you clarify ? There is an executor pool (max size : 1 for now) and a socketOutputStreamPool in GraphiteMetricsManager. How many of these would there be? > Currently it is true we could use only one socket and keep it open. > > Also, DescriptiveStatistics is not thread-safe (nor is StatCalculator). > It is not a problem, as DescriptiveStatistics is accessed synchronously. > > If we do implement something like this, I think the data processing needs > either to be carefully synchronised, or the raw data should be sent to a > separate singleton background thread. > I think it is carefully synchronized in the patch. If not please point me to where you see an issue. > > Follow-ups to the dev list please. > > -- > You are receiving this mail because: > You are the assignee for the bug. > -- Cordialement. Philippe Mouawad.
