Hi, Any feedback on this ? Is there a technical reason except for SaveService why those $Revision are here ?
I think for maintainbility they should be removed where they are useless. Regards Philippe On Sat, Oct 17, 2015 at 6:08 PM, Philippe Mouawad < [email protected]> wrote: > If they are useless why keep them ? > We have coding style strategies that say that : > - empty comments should be removed > - dead code should be removed > ... > > So if there are useless, they should be removed ? Even if they do not harm > (as Empty comment do not hurt neither). > > Unless there is a good reason, for example related to the svn to git > migration . > > Regards > Philippe > > On Sat, Oct 17, 2015 at 5:47 PM, sebb <[email protected]> wrote: > >> Why remove the marker? >> Is it doing any harm? >> >> On 17 October 2015 at 14:36, Philippe Mouawad >> <[email protected]> wrote: >> > Hi, >> > Any feedback on this ? >> > Thanks >> > >> > On Sat, Oct 3, 2015 at 9:52 PM, Philippe Mouawad < >> [email protected] >> >> wrote: >> > >> >> Hello, >> >> Some classes contain this javadoc. >> >> But a lot do not. >> >> >> >> Except for SaveService there does not seem to be any need of this. >> >> >> >> I propose to remove it from code. >> >> >> >> Regards >> >> Philippe >> >> >> >> >> > >> > >> > -- >> > Cordialement. >> > Philippe Mouawad. >> > > > > -- > Cordialement. > Philippe Mouawad. > > > -- Cordialement. Philippe Mouawad.
