Hi all,

why should we have setSampleConsumer and addSampleConsumer in a newly added class, when they have no different behaviour?

It is especially confusing, when both are used in one method (ReportGenerator#generate).

I would tend to remove setSampleConsumer, since the behaviour of that method is to add a consumer instead of replacing one.

Regards,
 Felix

Reply via email to