@sebb, I am responsible if this commit, I was going to fix it this evening but you did it before, thanks.
I think: - we should highlight somewhere - or/and add "checkstyle" to "package" ant task so that builld fails - or/and follow Vladimir's proposal. Anyway, my strategy is the following: - I prefer a contribution that improves the product even if it contains tab spaces. Now that you created the check it is easy to find so it is a little problem. - I think we should be nice with patch providers and developers who work on their personal time to improve JMeter. Finally as the french say says: - "On ne fait pas d'omelette sans casser des oeufs" Regards Philippe On Thu, Feb 4, 2016 at 4:50 PM, Vladimir Sitnikov < [email protected]> wrote: > >However Travis and Jenkins are run on the checked-in source - it's > >already too late. > > Can Jenkins be integrated with Github PRs? It could be possible. > > Travis can definitely check at the pull request level. > It is extremely useful for those who provide Github PRs. Even if the > patch has to be converted to bugzilla later. > > Codecov.io can track code coverage (that is it tracks if pull request > adds a sampler that is not covered by the unit tests). > > Here's an example: > https://github.com/pgjdbc/pgjdbc/pull/493#issuecomment-172622681 > > Vladimir > -- Cordialement. Philippe Mouawad.
