Github user milamberspace commented on a diff in the pull request:

    https://github.com/apache/jmeter/pull/91#discussion_r52122001
  
    --- Diff: src/core/org/apache/jmeter/gui/util/JSyntaxTextArea.java ---
    @@ -90,6 +95,9 @@ public JSyntaxTextArea(int rows, int cols, boolean 
disableUndo) {
             super.setLineWrap(LINE_WRAP);
             super.setWrapStyleWord(WRAP_STYLE_WORD);
             this.disableUndo = disableUndo;
    +        if(USER_FONT_FAMILY!=null) {
    +            setFont(new Font(USER_FONT_FAMILY, Font.PLAIN, 
USER_FONT_SIZE));
    --- End diff --
    
    @d0k1 your PR have a bug: when the jsyntaxtextarea.font.size property is 
defined and jsyntaxtextarea.font.family is *not* defined, the size is not 
change on the textarea.
    Probably, you must define the default value to 
"JSyntaxTextArea.getDefaultFont().getName()" the USER_FONT_FAMILY constants, 
and remove this if condition.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to