On 19 February 2016 at 08:00, Philippe Mouawad <philippe.moua...@gmail.com> wrote: > On Friday, February 19, 2016, Felix Schumacher < > felix.schumac...@internetallee.de> wrote: > >> >> >> Am 19. Februar 2016 00:47:04 MEZ, schrieb Philippe Mouawad < >> philippe.moua...@gmail.com <javascript:;>>: >> >Hi, >> >I added the tests and now issue is detected. >> >I commited the fix to Bug 58099 fixing regression. >> >> There is another bug open, to remove all references to apache.org. >
It's not just apache.org; ideally we should not rely on any external servers. > > what https server can we use then ? HC Unit tests use Jetty; I've not checked if they use it for HTTPS tests. >> >> Could we start a local server with sni enabled ssl connector? > > I don't see how to do it from within tests > > There are other tests we need: > - invalid certificate > - slow socket > - client certificate > - ssl context caching or not > > >> >> > >> >But I think next test will still fail due to this in logs: >> >WARN - jmeter.util.SSLManager: Keystore file not found, loading empty >> >keystore >> > >> >What shall we do about that ? >> >> Fill the used truststore with the necessary keys, or use one, that accepts >> any certificate? For the time being I have changed the properties so the WARN message is not logged. But ideally the test should use a valid keystore. Given that it seems happy with an empty keystore, that should be reasonably easy to fix. Alternatively maybe the message does not deserve to be a WARNing. >> >> Regards, >> Felix >> >> >Regards >> >Philippe >> > >> >On Fri, Feb 19, 2016 at 12:18 AM, Philippe Mouawad < >> >philippe.moua...@gmail.com <javascript:;>> wrote: >> > >> >> Hello, >> >> I broke HTTPS in JMeter with commit 1730947. >> >> >> >> I will fix it in few minutes. >> >> >> >> But it is strange that no JUnit test caught this big issue. >> >> >> >> I will commit a Test Plan testing HTTPS and SNI. >> >> >> >> -- >> >> Regards. >> >> Philippe M. >> >> >> >> > > -- > Cordialement. > Philippe Mouawad.
