Hi Felix, Do you want me to change the commit log ? What can I improve ? Do you think I should have added the commits that changed labels and documentation of fields ?
The issue for this bug was that I used initially the wrong property (MaxConnLifetimeMillis) when switching to DBCP from Excalibur, and that the concept does not exist in DBCP, so I had to change fields and documentation. Thanks Regards On Wed, Feb 24, 2016 at 9:53 AM, Felix Schumacher < [email protected]> wrote: > > > Am 23. Februar 2016 21:12:26 MEZ, schrieb [email protected]: > >Author: pmouawad > >Date: Tue Feb 23 20:12:26 2016 > >New Revision: 1731938 > > > >URL: http://svn.apache.org/viewvc?rev=1731938&view=rev > >Log: > >Bug 59051 - JDBC Request : Connection is closed by pool if it exceeds > >the configured lifetime > >Bugzilla Id: 59051 > > > >Modified: > > >jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElement.java > > jmeter/trunk/xdocs/changes.xml > > > >Modified: > > >jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElement.java > >URL: > > > http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElement.java?rev=1731938&r1=1731937&r2=1731938&view=diff > > >============================================================================== > >--- > > >jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElement.java > >(original) > >+++ > > >jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElement.java > >Tue Feb 23 20:12:26 2016 > >@@ -210,7 +210,7 @@ public class DataSourceElement extends A > > if(isKeepAlive()) { > > dataSource.setTestWhileIdle(true); > > dataSource.setValidationQuery(getCheckQuery()); > >- > >dataSource.setMaxConnLifetimeMillis(Long.parseLong(getConnectionAge())); > > > >+ > > >dataSource.setSoftMinEvictableIdleTimeMillis(Long.parseLong(getConnectionAge())); > > >dataSource.setTimeBetweenEvictionRunsMillis(Integer.parseInt(getTrimInterval())); > > } > > > > > >Modified: jmeter/trunk/xdocs/changes.xml > >URL: > > > http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1731938&r1=1731937&r2=1731938&view=diff > > >============================================================================== > >--- jmeter/trunk/xdocs/changes.xml (original) > >+++ jmeter/trunk/xdocs/changes.xml Tue Feb 23 20:12:26 2016 > >@@ -182,7 +182,7 @@ Summary > >Implemented by Andrey Pokhilko (andrey at blazemeter.com) and > >contributed by BlazeMeter Ltd.</li> > ><li><bug>58100</bug>Performance enhancements : Replace Random by > >ThreadLocalRandom.</li> > ><li><bug>58465</bug>JMS Read response field is badly named and > >documented</li> > >-<li><bug>58601</bug>Change check for modification of > ><code>saveservice.properties</code> from <code>$Revision$</code> to > >sha1 sum of the file itself.</li> > >+<li><bug>58601</bug>Change check for modification of > ><code>saveservice.properties</code> from <code>SVN Revision ID</code> > >to sha1 sum of the file itself.</li> > > This change was unexpected for me, just by reading the commit message. > > It is ok, though. > > Regards, > Felix > > ><li><bug>58677</bug>TestSaveService#testLoadAndSave use the wrong set > >of files. Contributed by Benoit Wiart (benoit dot wiart at > >gmail.com)</li> > ><li><bug>58679</bug>Replace the xpp pull parser in xstream with a > >java6+ standard solution. Contributed by Benoit Wiart (benoit dot wiart > >at gmail.com)</li> > ><li><bug>58689</bug>Add shortcuts to expand / collapse a part of the > >tree. Contributed by Benoit Wiart (benoit dot wiart at gmail.com)</li> > >@@ -275,6 +275,7 @@ Summary > ><li><bug>58851</bug>Add a dependency to hamcrest-core to allow JUnit > >tests with annotations to work</li> > ><li><bug>58947</bug>Connect metric is wrong when ConnectException > >occurs</li> > ><li><bug>58980</bug>JMS Subscriber will return successful as long as 1 > >message is received. Contributed by Harrison Termotto (harrison dot > >termotto at stonybrook.edu)</li> > >+ <li><bug>59051</bug>JDBC Request : Connection is closed by pool if > >it exceeds the configured lifetime (affects nightly build as of 23 fev > >2016).</li> > > </ul> > > > > <h3>Controllers</h3> > > -- Cordialement. Philippe Mouawad.
