Github user ham1 commented on the pull request:
https://github.com/apache/jmeter/pull/131#issuecomment-199507116
@FSchumacher thank you for applying most of my changes. I've updated the PR
and there are a few more minor things left. Regarding the spelling of that
constant, I agree, it's probably better to be slightly wrong but consistent
than inconsistent.
Regarding the delete vs. deprecate, deprecation is probably a good first
step, but as it's a protected method and it's not used in any of the subclasses
it seems unlikely that someone is using it?
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
