On 22 March 2016 at 19:12, Philippe Mouawad <philippe.moua...@gmail.com> wrote: > Hello sebb, > Although this fixes the issue, it seems to me as a violation of the > architecture . > BackendListener should not be aware of a particular implementation of > BackendListenerClient : GraphiteBackendListenerClient
If you can move the fix into GraphiteBackendListenerClient please do so. > Regards > > On Tue, Mar 22, 2016 at 1:54 AM, <s...@apache.org> wrote: > >> Author: sebb >> Date: Tue Mar 22 00:54:30 2016 >> New Revision: 1736119 >> >> URL: http://svn.apache.org/viewvc?rev=1736119&view=rev >> Log: >> New fields/changed defaults cause earlier test plans to be marked as >> changed >> Fix BackendListener >> Bugzilla Id: 59173 >> >> Modified: >> >> jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java >> >> Modified: >> jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java >> URL: >> http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java?rev=1736119&r1=1736118&r2=1736119&view=diff >> >> ============================================================================== >> --- >> jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java >> (original) >> +++ >> jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java >> Tue Mar 22 00:54:30 2016 >> @@ -39,6 +39,7 @@ import org.apache.jmeter.testelement.Abs >> import org.apache.jmeter.testelement.TestElement; >> import org.apache.jmeter.testelement.TestStateListener; >> import org.apache.jmeter.testelement.property.TestElementProperty; >> +import >> org.apache.jmeter.visualizers.backend.graphite.GraphiteBackendListenerClient; >> import org.apache.jorphan.logging.LoggingManager; >> import org.apache.log.Logger; >> >> @@ -434,6 +435,9 @@ public class BackendListener extends Abs >> * the new arguments. These replace any existing arguments. >> */ >> public void setArguments(Arguments args) { >> + // Bug 59173 - don't save new default argument >> + >> args.removeArgument(GraphiteBackendListenerClient.USE_REGEXP_FOR_SAMPLERS_LIST, >> + >> GraphiteBackendListenerClient.USE_REGEXP_FOR_SAMPLERS_LIST_DEFAULT); >> setProperty(new TestElementProperty(ARGUMENTS, args)); >> } >> >> >> >> > > > -- > Cordialement. > Philippe Mouawad.
