On 3 April 2016 at 13:48, pmouawad <[email protected]> wrote: > Github user pmouawad commented on the pull request: > > https://github.com/apache/jmeter/pull/176#issuecomment-204965711 > > Hi Vladimir, > Exposing public method for testing might introduce issues. > Users can think that field is persisted in JMX while it's not. > > Can't it be package protected ? >
Huh? Looks to me as though it is package protected. But it would be good to add a comment to say it is only for unit tests. Not sure the Javadoc is needed for package methods; it may suggest these methods is supported, so I would replace it with something like: // for unit testing purposes only > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at [email protected] or file a JIRA ticket > with INFRA. > ---
