Thank you for your contribution proposal. It appears rather clean but I wonder if a select box instead of radio button might not be a better option for extending Sampler. If we want to add another command it will be easier as it wont require gui change and place won't be a problem. If you can make the changes I'll be happy to merge it after release of 3.0 Regards Philippe On Saturday, April 9, 2016, Pierre ROUDIER <[email protected]> wrote:
> Hello, > > I needed the ability to send the LIST FTP command from the FTPSampler for a > test scenario at work. So I forked the project on GitHub and gave it a go. > The result can be seen here: > > https://github.com/proudier/jmeter/commit/ff103720ee0d5f9b43dc54f56eb5778757bed936 > > Key aspects: > - As the original FTPSampler used a boolean "Upload" flag , I had to > refactor some code to allow for a "switch compliant" architecture. > Consequently, the FTPSampler.upload property had to be replaced with a > FTPSampler.command. > - The sampler understands both properties, so that unmodified .jmx can be > ran as before. > - The conversion from the legacy property to the new one is performed upon > loading in the GUI. Thus, after saving, the .jmx file hold the proper > property. > > I ran the following tests: > - ant checkstyle => OK > - ant test => OK > - and I've been using the whole thing at my work place for 3 weeks > > I'd be happy to hear your comments and make the necessary adjustments > before making the pull-request. > > Best regards > Pierre > -- Cordialement. Philippe Mouawad.
