But wasn't it non final in previous commit ? On Tue, Apr 19, 2016 at 4:13 PM, sebb <seb...@gmail.com> wrote:
> On 19 April 2016 at 13:54, Felix Schumacher > <felix.schumac...@internetallee.de> wrote: > > > > > > Am 19. April 2016 14:40:57 MESZ, schrieb s...@apache.org: > >>Author: sebb > >>Date: Tue Apr 19 12:40:57 2016 > >>New Revision: 1739924 > >> > >>URL: http://svn.apache.org/viewvc?rev=1739924&view=rev > >>Log: > >>Field can still be final > >> > >>Modified: > >>jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java > >> > >>Modified: > >>jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java > >>URL: > >> > http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java?rev=1739924&r1=1739923&r2=1739924&view=diff > > >>============================================================================== > >>--- > >>jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java > >>(original) > >>+++ > >>jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java > >>Tue Apr 19 12:40:57 2016 > >>@@ -32,10 +32,8 @@ import org.slf4j.helpers.MessageFormatte > >> */ > >>public class LogkitLoggerAdapter extends MarkerIgnoringBase implements > >>Serializable { > >> > >>- transient Logger logger; > >>- /** > >>- * > >>- */ > >>+ final transient Logger logger; > > > > Is this really valid? When an object of This class gets deserialized, > its transient fields will not be initialized. But they are marked as non > changing and thus stay in that state. > > > > Looks strange to me. > > That's one reason why I asked if it needed to be Serializable. > > > Felix > > > >>+ > >> private static final long serialVersionUID = -122848886791823355L; > >> > >> /** > >>@@ -44,6 +42,7 @@ public class LogkitLoggerAdapter extends > >> @Deprecated // only for Unit test usage > >> public LogkitLoggerAdapter() { > >> super(); > >>+ this.logger = null; > >> } > >> > >> LogkitLoggerAdapter(org.apache.log.Logger logkitLogger) { > > > -- Regards Ubik Load Pack <http://ubikloadpack.com> Team Follow us on Twitter <http://twitter.com/ubikloadpack> Cordialement L'équipe Ubik Load Pack <http://ubikloadpack.com> Suivez-nous sur Twitter <http://twitter.com/ubikloadpack>
