On 19 April 2016 at 23:44, Vladimir Sitnikov <sitnikov.vladi...@gmail.com> wrote: > sebb>Yes, but is a stack trace necessary here? > sebb>So long as it's obvious what the problem is and how to fix it without > > You do not think "catch (Exception e)" is obvious, do you?
Depends. > What if it fails with NPE in unknown line? Then I agree the stack trace is needed. However for most cases it probably is not; I think the problem here is that the catch is too broad. I would probably catch the more obvious exceptions and let anything else ripple up. Looking at it again, I wonder why the catch was changed from ConversionException? The log message does not say. > Vladimir
