Hi, Modifications in the PR done
Antonio 2017-03-06 15:51 GMT+01:00 Antonio Gomes Rodrigues <ra0...@gmail.com>: > Hi Philippe > > 2017-03-06 8:40 GMT+01:00 Philippe Mouawad <philippe.moua...@gmail.com>: > >> Hello Antonio, >> I 've reviewed it rapidly: >> - button at the bottom => In nightly build it is at top now and buttons >> have changed >> > Ok, I will modify it > > >> - With the gui, but it's not recommended to big load test => With the gui, >> but just during debug phase, use Non GUI for your load test. >> > Ok, I will modify it > > >> >> I think you should mention that between Validation phase and Run phase >> there is variabilization and Correlation phase. >> > Not added because it's not present in the original document > I will mention it and add some tips > > Antonio > >> >> Thanks >> Regards >> >> On Sun, Mar 5, 2017 at 7:10 PM, Antonio Gomes Rodrigues <ra0...@gmail.com >> > >> wrote: >> >> > Hi, >> > >> > I have modified jmeter proxy step by step document >> > >> > See my modifications in https://github.com/apache/jmeter/pull/279 >> > >> > If it's ok, I will commit it in svn >> > >> > Antonio >> > >> > 2017-03-02 10:47 GMT+01:00 Maxime Chassagneux < >> > maxime.chassagn...@gmail.com> >> > : >> > >> > > Hi, >> > > >> > > I have to update some screen + documentation for the JMS change made >> by >> > me. >> > > I will do it ASAP. >> > > >> > > >> > > 2017-03-01 23:36 GMT+01:00 Antonio Gomes Rodrigues <ra0...@gmail.com >> >: >> > > >> > > > 2017-03-01 23:03 GMT+01:00 Philippe Mouawad < >> > philippe.moua...@gmail.com >> > > >: >> > > > >> > > > > On Wed, Mar 1, 2017 at 10:59 PM, Antonio Gomes Rodrigues < >> > > > ra0...@gmail.com >> > > > > > >> > > > > wrote: >> > > > > >> > > > > > Hi, >> > > > > > >> > > > > > 1. >> > > > > > One question, in jmeter_tutorial.html file we talk about a >> > screenshot >> > > > > which >> > > > > > exit in pdf file but not in html file: "From the screen >> capture, we >> > > see >> > > > > the >> > > > > > following directories. " >> > > > > > >> > > > > > I propose to remove this sentence instead of adding the screen >> > > > > > >> > > > > >> > > > > +1 >> > > > > >> > > > >> > > > Done >> > > > >> > > > > >> > > > > > >> > > > > > >> > > > > > Later we talk about: >> > > > > > >> > > > > > "monitortomcat 5 monitor components" >> > > > > > >> > > > > > >> > > > > > "htmlparsera snapshot of HtmlParser, donated by HtmlParser >> project >> > on >> > > > > > sourceforge" >> > > > > > >> > > > > > These folders don't exist anymore, can I remove them? >> > > > > > >> > > > > +1 >> > > > > >> > > > >> > > > Done >> > > > >> > > > > >> > > > > > >> > > > > > >> > > > > > If you are ok, I can make the modifications now >> > > > > > >> > > > > > >> > > > > > 2. >> > > > > > >> > > > > > About jmeter_accesslog_sampler_step_by_step.html file >> > > > > > >> > > > > > My opinion is that this is a gadget and I have never seen >> someone >> > > make >> > > > > > serious load test with access.log file (no correlation between >> > > url...) >> > > > > > >> > > > > > I think we need to remove it from homepage >> > > > > > >> > > > > >> > > > > +0, I have seen some blogs about this feature. >> > > > > It can suit some use cases where correlation is not needed. >> > > > > >> > > > In these conditions, I think we need to had more general cases where >> > > access >> > > > logs might be inappropriate. >> > > > I will work on it tomorrow >> > > > >> > > > >> > > > > >> > > > > > >> > > > > > >> > > > > > 3. >> > > > > > >> > > > > > About jmeter_proxy_step_by_step.html >> > > > > > >> > > > > > I think we need to write it again to talk to all the new >> features >> > > > > > (template...) >> > > > > > >> > > > > > I can do it this week >> > > > > > >> > > > > +1 >> > > > > >> > > > > > >> > > > > > >> > > > > > >> > > > > > Antonio >> > > > > > >> > > > > > >> > > > > > 2017-03-01 22:30 GMT+01:00 Antonio Gomes Rodrigues < >> > ra0...@gmail.com >> > > >: >> > > > > > >> > > > > > > Hi, >> > > > > > > >> > > > > > > my fault, the PDF links have been removed >> > > > > > > >> > > > > > > I check the 5 files and give a feedback asap >> > > > > > > >> > > > > > > Antonio >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > 2017-03-01 22:16 GMT+01:00 Philippe Mouawad < >> > > > > philippe.moua...@gmail.com >> > > > > > >: >> > > > > > > >> > > > > > >> Hi Antonio, >> > > > > > >> I removed PDF links, are you sure you generated last docs ? >> > > > > > >> Thanks >> > > > > > >> >> > > > > > >> On Wed, Mar 1, 2017 at 10:14 PM, Antonio Gomes Rodrigues < >> > > > > > >> ra0...@gmail.com> >> > > > > > >> wrote: >> > > > > > >> >> > > > > > >> > Thanks, >> > > > > > >> > >> > > > > > >> > Is it normal that pdf file still exist and the link in the >> > left >> > > > > > >> (Tutorials >> > > > > > >> > (PDF format)) are sill to pdf files? >> > > > > > >> > >> > > > > > >> > Antonio >> > > > > > >> > >> > > > > > >> > 2017-03-01 21:52 GMT+01:00 Felix Schumacher < >> > > > > > >> > felix.schumac...@internetallee.de>: >> > > > > > >> > >> > > > > > >> > > Am 01.03.2017 um 21:07 schrieb Antonio Gomes Rodrigues: >> > > > > > >> > > >> > > > > > >> > >> Hi, >> > > > > > >> > >> >> > > > > > >> > >> About " Ensure the migrated docs (from PDF) do not >> contain >> > > old >> > > > > > "Urban >> > > > > > >> > >> legends" >> > > > > > >> > >> :-) nor bad practices. Those are the 4 Tutorial >> links >> > in >> > > > left >> > > > > > >> menu. >> > > > > > >> > It >> > > > > > >> > >> would be nice to review them. I've fixed some but >> not >> > > done >> > > > > the >> > > > > > >> full >> > > > > > >> > >> work" >> > > > > > >> > >> >> > > > > > >> > >> Which files are? >> > > > > > >> > >> >> > > > > > >> > > Look for xml files in the xdocs folder, which are named >> as >> > the >> > > > > > >> tutorials >> > > > > > >> > > on the jmeter homepage in the menu. They should be: >> > > > > > >> > > >> > > > > > >> > > xdocs/usermanual/jmeter_distributed_testing_step_by_ >> > step.xml >> > > > > > >> > > xdocs/usermanual/jmeter_proxy_step_by_step.xml >> > > > > > >> > > xdocs/usermanual/junitsampler_tutorial.xml >> > > > > > >> > > xdocs/usermanual/jmeter_access >> log_sampler_step_by_step.xml >> > > > > > >> > > xdocs/usermanual/jmeter_tutorial.xml >> > > > > > >> > > >> > > > > > >> > > Felix >> > > > > > >> > > >> > > > > > >> > > >> > > > > > >> > > >> > > > > > >> > >> Thanks >> > > > > > >> > >> Antonio >> > > > > > >> > >> >> > > > > > >> > >> 2017-03-01 10:44 GMT+01:00 Antonio Gomes Rodrigues < >> > > > > > ra0...@gmail.com >> > > > > > >> >: >> > > > > > >> > >> >> > > > > > >> > >> Hi, >> > > > > > >> > >>> >> > > > > > >> > >>> 2017-02-28 22:54 GMT+01:00 Philippe Mouawad < >> > > > > > >> > philippe.moua...@gmail.com >> > > > > > >> > >>> >: >> > > > > > >> > >>> >> > > > > > >> > >>> Hello, >> > > > > > >> > >>>> We're now at: >> > > > > > >> > >>>> >> > > > > > >> > >>>> - 48 Enhancements >> > > > > > >> > >>>> - 31 bug fixes >> > > > > > >> > >>>> >> > > > > > >> > >>>> Sebb has fixed Windows failures on Jenkins >> > > > > > >> > >>>> >> > > > > > >> > >>>> - Ensure the migrated docs (from PDF) do not >> contain >> > > old >> > > > > > "Urban >> > > > > > >> > >>>> legends" >> > > > > > >> > >>>> :-) nor bad practices. Those are the 4 Tutorial >> links >> > > in >> > > > > left >> > > > > > >> > menu. >> > > > > > >> > >>>> It >> > > > > > >> > >>>> would be nice to review them. I've fixed some but >> not >> > > > done >> > > > > > the >> > > > > > >> > full >> > > > > > >> > >>>> work >> > > > > > >> > >>>> >> > > > > > >> > >>>> TODO >> > > > > > >> > >>>> >> > > > > > >> > >>>> I will check them today >> > > > > > >> > >>> >> > > > > > >> > >>> >> > > > > > >> > >>> >> > > > > > >> > >>> - Fill in introduced properties in >> > > > properties_reference.xml >> > > > > > >> > >>>> >> > > > > > >> > >>>> DONE >> > > > > > >> > >>>> >> > > > > > >> > >>>> - If possible add JUnits on the regression >> introduced >> > > in >> > > > > GET >> > > > > > >> with >> > > > > > >> > no >> > > > > > >> > >>>> body (see my mail) >> > > > > > >> > >>>> >> > > > > > >> > >>>> DONE >> > > > > > >> > >>>> >> > > > > > >> > >>>> - Fill in New and Noteworthy section >> > > > > > >> > >>>> >> > > > > > >> > >>>> TODO >> > > > > > >> > >>>> >> > > > > > >> > >>>> >> > > > > > >> > >>>> Are you ok to start a release soon ? >> > > > > > >> > >>>> >> > > > > > >> > >>>> Ok >> > > > > > >> > >>> >> > > > > > >> > >>> >> > > > > > >> > >>> >> > > > > > >> > >>> Thanks >> > > > > > >> > >>>> >> > > > > > >> > >>>> Regards >> > > > > > >> > >>>> >> > > > > > >> > >>>> On Tue, Feb 21, 2017 at 4:21 PM, sebb < >> seb...@gmail.com> >> > > > > wrote: >> > > > > > >> > >>>> >> > > > > > >> > >>>> I'm seeing some test failures on Windows. >> > > > > > >> > >>>>> >> > > > > > >> > >>>>> I've started to set up a Jenkins build to be able to >> > catch >> > > > > > these. >> > > > > > >> > >>>>> (at present the failure mails are sent direct to me) >> > > > > > >> > >>>>> >> > > > > > >> > >>>>> Depending on the cause, the failures need to be fixed >> > > before >> > > > > the >> > > > > > >> next >> > > > > > >> > >>>>> release. >> > > > > > >> > >>>>> >> > > > > > >> > >>>>> On 11 February 2017 at 10:22, Philippe Mouawad >> > > > > > >> > >>>>> <philippe.moua...@gmail.com> wrote: >> > > > > > >> > >>>>> >> > > > > > >> > >>>>>> Hello, >> > > > > > >> > >>>>>> Since our discussion on "Release a 3.2 ?" , trunk >> has >> > > > nicely >> > > > > > >> > evolved: >> > > > > > >> > >>>>>> >> > > > > > >> > >>>>>> - 33 Enhancements >> > > > > > >> > >>>>>> - 25 bug fixes >> > > > > > >> > >>>>>> >> > > > > > >> > >>>>>> I think we can now plan a release. >> > > > > > >> > >>>>>> >> > > > > > >> > >>>>>> I see the following remaining work: >> > > > > > >> > >>>>>> >> > > > > > >> > >>>>>> - Ensure the migrated docs (from PDF) do not >> > contain >> > > > old >> > > > > > >> "Urban >> > > > > > >> > >>>>>> >> > > > > > >> > >>>>> legends" >> > > > > > >> > >>>>> >> > > > > > >> > >>>>>> :-) nor bad practices. Those are the 4 Tutorial >> > links >> > > > in >> > > > > > left >> > > > > > >> > >>>>>> >> > > > > > >> > >>>>> menu. It >> > > > > > >> > >>>> >> > > > > > >> > >>>>> would be nice to review them. I've fixed some but >> > not >> > > > done >> > > > > > the >> > > > > > >> > full >> > > > > > >> > >>>>>> >> > > > > > >> > >>>>> work >> > > > > > >> > >>>>> >> > > > > > >> > >>>>>> - Fill in introduced properties in >> > > > > properties_reference.xml >> > > > > > >> > >>>>>> - If possible add JUnits on the regression >> > introduced >> > > > in >> > > > > > GET >> > > > > > >> > with >> > > > > > >> > >>>>>> >> > > > > > >> > >>>>> no >> > > > > > >> > >>>> >> > > > > > >> > >>>>> body (see my mail) >> > > > > > >> > >>>>>> - Fill in New and Noteworthy section >> > > > > > >> > >>>>>> >> > > > > > >> > >>>>>> >> > > > > > >> > >>>>>> >> > > > > > >> > >>>>>> -- >> > > > > > >> > >>>>>> Cordialement. >> > > > > > >> > >>>>>> Philippe Mouawad. >> > > > > > >> > >>>>>> >> > > > > > >> > >>>>> >> > > > > > >> > >>>> >> > > > > > >> > >>>> -- >> > > > > > >> > >>>> Cordialement. >> > > > > > >> > >>>> Philippe Mouawad. >> > > > > > >> > >>>> >> > > > > > >> > >>>> >> > > > > > >> > >>> >> > > > > > >> > > >> > > > > > >> > >> > > > > > >> >> > > > > > >> >> > > > > > >> >> > > > > > >> -- >> > > > > > >> Cordialement. >> > > > > > >> Philippe Mouawad. >> > > > > > >> >> > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > > >> > > > > >> > > > > -- >> > > > > Cordialement. >> > > > > Philippe Mouawad. >> > > > > >> > > > >> > > >> > >> >> >> >> -- >> Cordialement. >> Philippe Mouawad. >> > >