Github user max3163 commented on the issue:
https://github.com/apache/jmeter/pull/283
Hi,
No problem to delay it after 3.2.
I will include it in our own build and test it on a large scale.
I will think about JUnit to cover it as soon as possible.
Thanks again for your feedback.
Regards
--
Max
2017-03-10 19:57 GMT+01:00 Philippe M <notificati...@github.com>:
> Hello Maxime,
> Thanks for patch.
> My remarks:
>
> -
>
> I think we need here JUnit tests to check no regression will occur.
> This part of the code is complex and critical and needs 100% coverage
> ideally through JUnit otherwise with a test plan running with Jacoco
> -
>
> I would prefer to delay it after 3.2 release to avoid introducing
> another delay in release.
>
> I'll review code more thoroughly in near future.
>
> Regards
> Philippe
>
> â
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/jmeter/pull/283#issuecomment-285754234>, or
mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/ANMcZmviGUxaOWiQ3NIJDCxI82f5wg4Iks5rkZ0AgaJpZM4MZc7q>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
