I don't know the codebase but why bother marking the old method as @Deprecated if you are not making the change backwards compatible?
I see 'return null' in two existing methods while previously those methods returned something. A proper pattern would have been to call read(is, null) or read(is, new DummySampleResult()). --emi On Thu, Sep 7, 2017 at 11:25 PM, pmouawad <[email protected]> wrote: > Github user pmouawad commented on the issue: > > https://github.com/apache/jmeter/pull/306 > > Hello > Unless there is a NO GO , I'll commit this tomorrow. > > Thanks > > > --- >
