[GitHub] jmeter pull request #321: [Influxdb] Allow users to add theirs owns tags

[pmouawad]

Github user pmouawad commented on a diff in the pull request:

    https://github.com/apache/jmeter/pull/321#discussion_r149133328
  
    --- Diff: 
src/components/org/apache/jmeter/visualizers/backend/influxdb/InfluxdbBackendListenerClient.java
 ---
    @@ -318,6 +335,13 @@ public void setupTest(BackendListenerContext context) 
throws Exception {
                     }
                 }
             }
    +        // Check if more fields are filled ( corresponding to user tag )
    +        context.getParameterNamesIterator().forEachRemaining(name->{
    +            if ( !defaultArg.containsKey(name)) {
    +                TAG_USER += "," + 
AbstractInfluxdbMetricsSender.tagToStringValue(name.trim()) + "=" + 
AbstractInfluxdbMetricsSender.tagToStringValue(context.getParameter(name).trim());
    --- End diff --
    
    Thanks for this PR. It would require more documentation as I find the usage 
a bit edgy. AFAIU you 'll enable user to add as many rows (key=value) which 
will be tags for Influx event.
    Can't we have some meaningful prefix or something to avoid a conflict 
between a user tag and a real property of the InfluxdbBackendListenerClient ?


---