Hi, First test of Darcula theme on windows for me, I find the rendering of texteara ugly ( too black & white ! ) .... I'm the only one with this effect ? :
https://www.dropbox.com/s/8h08xu0l3oj2ujt/%231.png?dl=0 https://www.dropbox.com/s/grlasbkbxuscliv/%232.png?dl=0 2017-11-21 21:50 GMT+01:00 Antonio Gomes Rodrigues <ra0...@gmail.com>: > Work fine in my Linux > > Antonio > > 2017-11-21 20:28 GMT+01:00 Milamber <milam...@apache.org>: > > > > > > > On 21/11/2017 12:36, Philippe Mouawad wrote: > > > >> Hello, > >> Thanks Antonio for your tests, I indeed was using laf name instead of > >> class > >> name. > >> It is working now in my tests, but Milamber, Antonio or any subscriber, > >> your tests are welcome. > >> > > > > That's works for default LAF after remove theses lines into this file > > ~/.java/.userPrefs/org/apache/jmeter/gui/action/prefs.xml > > > > (removed) > > <entry key="laf" value="com.bulenkov.darcula.DarculaLaf"/> > > <entry key="laf.class" value="javax.swing.plaf.metal.MetalLookAndFeel"/> > > > > > > Thanks > > > > Jenkins build is in progress, a new nightly build should be available in > >> few minutes. > >> Regards > >> > >> On Tue, Nov 21, 2017 at 10:17 AM, Philippe Mouawad < > >> philippe.moua...@gmail.com> wrote: > >> > >> Hi Antonio, > >>> I fixed this bug on sunday. > >>> Are you using last revision ? > >>> > >>> Thanks > >>> > >>> On Tue, Nov 21, 2017 at 10:14 AM, Antonio Gomes Rodrigues < > >>> ra0...@gmail.com> wrote: > >>> > >>> Hi Philippe, > >>>> > >>>> About Darcula, in Windows 10 (I will test it in Linux later but I > think > >>>> it's the same) we have in the first launch > >>>> > >>>> 2017-11-21 10:09:26,333 INFO o.a.j.g.a.LookAndFeelCommand: Installing > >>>> Darcula LAF > >>>> 2017-11-21 10:09:26,363 INFO o.a.j.g.a.LookAndFeelCommand: Using look > >>>> and > >>>> feel: Darcula [] > >>>> 2017-11-21 10:09:26,363 INFO o.a.j.JMeter: Setting LAF to: Darcula > >>>> 2017-11-21 10:09:26,363 WARN o.a.j.JMeter: Could not set LAF to: > Darcula > >>>> java.lang.ClassNotFoundException: Darcula > >>>> at java.net.URLClassLoader.findClass(Unknown Source) ~[?:1.8.0_144] > >>>> at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_144] > >>>> at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_144] > >>>> at java.lang.Class.forName0(Native Method) ~[?:1.8.0_144] > >>>> at java.lang.Class.forName(Unknown Source) ~[?:1.8.0_144] > >>>> at javax.swing.SwingUtilities.loadSystemClass(Unknown Source) > >>>> ~[?:1.8.0_144] > >>>> at javax.swing.UIManager.setLookAndFeel(Unknown Source) > ~[?:1.8.0_144] > >>>> at org.apache.jmeter.JMeter.startGui(JMeter.java:359) > >>>> [ApacheJMeter_core.jar:r1815865] > >>>> at org.apache.jmeter.JMeter.start(JMeter.java:520) > >>>> [ApacheJMeter_core.jar:r1815865] > >>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > >>>> ~[?:1.8.0_144] > >>>> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) > >>>> ~[?:1.8.0_144] > >>>> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) > >>>> ~[?:1.8.0_144] > >>>> at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_144] > >>>> at org.apache.jmeter.NewDriver.main(NewDriver.java:248) > >>>> [ApacheJMeter.jar:r1815865] > >>>> > >>>> > >>>> In the second launch, all is ok > >>>> > >>>> 017-11-21 10:11:37,394 INFO o.a.j.g.a.LookAndFeelCommand: Installing > >>>> Darcula LAF > >>>> 2017-11-21 10:11:37,409 INFO o.a.j.g.a.LookAndFeelCommand: Using look > >>>> and > >>>> feel: com.bulenkov.darcula.DarculaLaf [Darcula] > >>>> 2017-11-21 10:11:37,409 INFO o.a.j.JMeter: Setting LAF to: > >>>> com.bulenkov.darcula.DarculaLaf > >>>> 2017-11-21 10:11:37,455 INFO o.a.j.JMeter: Loaded icon properties from > >>>> org/apache/jmeter/images/icon.properties > >>>> > >>>> Antonio > >>>> > >>>> > >>>> 2017-11-21 9:52 GMT+01:00 Philippe Mouawad < > philippe.moua...@gmail.com > >>>> >: > >>>> > >>>> Hi Milamber, > >>>>> One note below regarding LAF. > >>>>> > >>>>> Thanks > >>>>> > >>>>> On Tue, Nov 21, 2017 at 9:50 AM, Milamber <milam...@apache.org> > wrote: > >>>>> > >>>>> > >>>>>> On 20/11/2017 21:06, Philippe Mouawad wrote: > >>>>>> > >>>>>> Hello, > >>>>>>> We now have a version that contains: > >>>>>>> - 49 enhancements > >>>>>>> - 13 bug fixes > >>>>>>> - 6 PR > >>>>>>> > >>>>>>> Version looks mature to me currently and brings interesting new > >>>>>>> > >>>>>> features > >>>> > >>>>> and a nice new look. > >>>>>>> > >>>>>>> +1 for nice new look. (perhaps Dracula can be the default > look&feel) > >>>>>> > >>>>>> It is already. > >>>>> If it's not then it would be an issue, I intentionally changed the > >>>>> preference name for the laf so that all users have a chance to see > it. > >>>>> Can you double check and confirm please ? > >>>>> > >>>>> > >>>>>> What do you think of releasing ? > >>>>>>> > >>>>>>> Yes before end of the year that's will a good idea. > >>>>>> > >>>>>> > >>>>>> There are remaining PRs that could be merged but could introduce > more > >>>>>>> delay > >>>>>>> : > >>>>>>> > >>>>>>> - https://github.com/apache/jmeter/pull/320 => Migration to > >>>>>>> last > >>>>>>> > >>>>>> HC4 > >>>>> > >>>>>> APIs but it would need important tesint > >>>>>>> - https://github.com/apache/jmeter/pull/313 => I asked a > >>>>>>> > >>>>>> question > >>>> > >>>>> about > >>>>>>> it. I think we should adapt it to add a Metadata property > >>>>>>> > >>>>>> instead of > >>>> > >>>>> Comment > >>>>>>> > >>>>>>> > >>>>>>> Regards > >>>>>>> Philippe M. > >>>>>>> > >>>>>>> > >>>>>>> > >>>>> -- > >>>>> Cordialement. > >>>>> Philippe Mouawad. > >>>>> > >>>>> > >>> > >>> -- > >>> Cordialement. > >>> Philippe Mouawad. > >>> > >>> > >>> > >>> > >> > > >
