[GitHub] jmeter issue #346: Bug 61827 - TextFile always adds newline to end of string

Thu, 30 Nov 2017 18:07:54 -0800 

Github user codecov-io commented on the issue:

    https://github.com/apache/jmeter/pull/346
  
    # [Codecov](https://codecov.io/gh/apache/jmeter/pull/346?src=pr&el=h1) 
Report
    > Merging 
[#346](https://codecov.io/gh/apache/jmeter/pull/346?src=pr&el=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/4d8facc557fda5986837c3da3b2364350f08b368?src=pr&el=desc)
 will **increase** coverage by `<.01%`.
    > The diff coverage is `83.92%`.
    
    [![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/346/graphs/tree.svg?width=650&height=150&src=pr&token=6Q7CI1wFSh)](https://codecov.io/gh/apache/jmeter/pull/346?src=pr&el=tree)
    
    ```diff
    @@            Coverage Diff             @@
    ##             trunk    #346      +/-   ##
    ==========================================
    + Coverage     58.1%   58.1%   +<.01%     
    - Complexity   10111   10118       +7     
    ==========================================
      Files         1154    1155       +1     
      Lines        73961   73954       -7     
      Branches      7342    7339       -3     
    ==========================================
    - Hits         42972   42971       -1     
    + Misses       28509   28501       -8     
    - Partials      2480    2482       +2
    ```
    
    
    | [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/346?src=pr&el=tree) | Coverage 
Δ | Complexity Δ | |
    |---|---|---|---|
    | 
[...otocol/jms/sampler/render/TextMessageRenderer.java](https://codecov.io/gh/apache/jmeter/pull/346/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2ptcy9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9qbXMvc2FtcGxlci9yZW5kZXIvVGV4dE1lc3NhZ2VSZW5kZXJlci5qYXZh)
 | `100% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
    | 
[...otocol/jms/sampler/render/MessageRendererTest.java](https://codecov.io/gh/apache/jmeter/pull/346/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvam1zL3NhbXBsZXIvcmVuZGVyL01lc3NhZ2VSZW5kZXJlclRlc3QuamF2YQ==)
 | `100% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
    | 
[.../jms/sampler/render/BinaryMessageRendererTest.java](https://codecov.io/gh/apache/jmeter/pull/346/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvam1zL3NhbXBsZXIvcmVuZGVyL0JpbmFyeU1lc3NhZ2VSZW5kZXJlclRlc3QuamF2YQ==)
 | `82.97% <100%> (-0.36%)` | `14 <2> (ø)` | |
    | 
[...ol/jms/sampler/render/TextMessageRendererTest.java](https://codecov.io/gh/apache/jmeter/pull/346/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvam1zL3NhbXBsZXIvcmVuZGVyL1RleHRNZXNzYWdlUmVuZGVyZXJUZXN0LmphdmE=)
 | `100% <100%> (ø)` | `12 <1> (ø)` | :arrow_down: |
    | 
[test/src/org/apache/jorphan/io/TextFileSpec.groovy](https://codecov.io/gh/apache/jmeter/pull/346/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qb3JwaGFuL2lvL1RleHRGaWxlU3BlYy5ncm9vdnk=)
 | `100% <100%> (ø)` | `7 <7> (?)` | |
    | 
[.../jms/sampler/render/ObjectMessageRendererTest.java](https://codecov.io/gh/apache/jmeter/pull/346/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvam1zL3NhbXBsZXIvcmVuZGVyL09iamVjdE1lc3NhZ2VSZW5kZXJlclRlc3QuamF2YQ==)
 | `100% <100%> (ø)` | `11 <0> (ø)` | :arrow_down: |
    | 
[.../jmeter/protocol/jms/sampler/PublisherSampler.java](https://codecov.io/gh/apache/jmeter/pull/346/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2ptcy9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9qbXMvc2FtcGxlci9QdWJsaXNoZXJTYW1wbGVyLmphdmE=)
 | `61.49% <56.25%> (+0.57%)` | `36 <3> (ø)` | :arrow_down: |
    | 
[src/jorphan/org/apache/jorphan/io/TextFile.java](https://codecov.io/gh/apache/jmeter/pull/346/diff?src=pr&el=tree#diff-c3JjL2pvcnBoYW4vb3JnL2FwYWNoZS9qb3JwaGFuL2lvL1RleHRGaWxlLmphdmE=)
 | `39.53% <75%> (-7.44%)` | `7 <4> (ø)` | |
    | 
[...ocol/jms/sampler/render/BinaryMessageRenderer.java](https://codecov.io/gh/apache/jmeter/pull/346/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2ptcy9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9qbXMvc2FtcGxlci9yZW5kZXIvQmluYXJ5TWVzc2FnZVJlbmRlcmVyLmphdmE=)
 | `87.5% <0%> (-12.5%)` | `6% <0%> (ø)` | |
    | 
[...ocol/jms/org/apache/jmeter/protocol/jms/Utils.java](https://codecov.io/gh/apache/jmeter/pull/346/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2ptcy9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9qbXMvVXRpbHMuamF2YQ==)
 | `54.83% <0%> (-2.16%)` | `15% <0%> (ø)` | |
    | ... and [2 
more](https://codecov.io/gh/apache/jmeter/pull/346/diff?src=pr&el=tree-more) | |
    
    ------
    
    [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/346?src=pr&el=continue).
    > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing 
data`
    > Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/346?src=pr&el=footer). Last 
update 
[4d8facc...8196a06](https://codecov.io/gh/apache/jmeter/pull/346?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

Reply via email to