On Sun, Dec 10, 2017 at 1:05 PM, Felix Schumacher < [email protected]> wrote:
> Hi all, > > a few questions on the extract method. > > Does it have to be public? It seems to be called in > extractMatchingStrings, only. > It wasn't initially. It was made public for RenderAsBoundaryExtractor the Boundary renderer in View Results Tree > > If it stays public, shouldn't it have tests? > Yes > > Is the condition "matchNumber <= 0 || newFound != matchNumber" the correct > one? What happens when found is given with a number bigger than > matchNumber? Should we collect all matches? I think this should be > "newFound < matchNumber", that way we extract at most matchNumber (-1) > fragments. > Looks you're right. Feel free to fix it. Thanks > > Felix > > -- Cordialement. Philippe Mouawad.
