Thanks for follow up On Sun, Feb 18, 2018 at 11:20 AM, Felix Schumacher < felix.schumac...@internetallee.de> wrote:
> Am 15.02.2018 um 21:42 schrieb Philippe Mouawad: > >> On Thursday, February 15, 2018, Felix Schumacher < >> felix.schumac...@internetallee.de> wrote: >> >> Am 15.02.2018 um 21:35 schrieb Philippe Mouawad: >>> >>> On Thursday, February 15, 2018, Felix Schumacher < >>>> felix.schumac...@internetallee.de> wrote: >>>> >>>> Am Donnerstag, den 15.02.2018, 21:27 +0100 schrieb Philippe Mouawad: >>>> >>>>> Hi Felix, >>>>>> Can’t this have an impact on performances leading to a lot of error >>>>>> logging >>>>>> ? >>>>>> >>>>>> I don't think that the JUnitSampler is used for performance testing. >>>>> >>>>> I personnaly don’t but I am not sure about its usage. >>>> >>>> Me neither. >>> >>> >>> If it is, I hope that the testers will be smart enough to silence the >>>> >>>>> logging using the log configuration. Silenced log calls should have no >>>>> impact on performance. >>>>> >>>>> I suppose non junior would do. >>>> >>>> Should we change the log level to debug, then? >>> >> >> I don’t know. >> Or info, supposing user would set warn level for load test but it’s the >> same hypothesis. >> > I have lowered the level to info. OP has no problems with a lower level. > > Felix > > > >> >> Felix >>> >>> >>> Regards, >>>> >>>>> Felix >>>>> >>>>> Regards >>>>> >>>>>> On Thursday, February 15, 2018, <fschumac...@apache.org> wrote: >>>>>> >>>>>> Author: fschumacher >>>>>> >>>>>>> Date: Thu Feb 15 20:09:16 2018 >>>>>>> New Revision: 1824355 >>>>>>> >>>>>>> URL: http://svn.apache.org/viewvc?rev=1824355&view=rev >>>>>>> Log: >>>>>>> JUnitSampler logs exceptions except assertion-failures from test >>>>>>> cases as >>>>>>> warnings. >>>>>>> >>>>>>> Contributed by Davide Angelocola (davide.angelocola at >>>>>>> fisglobal.com) >>>>>>> Closes #376 on github >>>>>>> >>>>>>> Modified: >>>>>>> jmeter/trunk/src/junit/org/apache/jmeter/protocol/java/ >>>>>>> sampler/JUnitSampler.java >>>>>>> jmeter/trunk/xdocs/changes.xml >>>>>>> >>>>>>> Modified: jmeter/trunk/src/junit/org/apache/jmeter/protocol/java/ >>>>>>> sampler/JUnitSampler.java >>>>>>> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/junit/org/ >>>>>>> apache/jmeter/protocol/java/sampler/JUnitSampler.java?rev= >>>>>>> 1824355&r1=1824354&r2=1824355&view=diff >>>>>>> ============================================================ >>>>>>> ================== >>>>>>> --- >>>>>>> jmeter/trunk/src/junit/org/apache/jmeter/protocol/java/sampler/JUni >>>>>>> tSampler.java >>>>>>> (original) >>>>>>> +++ >>>>>>> jmeter/trunk/src/junit/org/apache/jmeter/protocol/java/sampler/JUni >>>>>>> tSampler.java >>>>>>> Thu Feb 15 20:09:16 2018 >>>>>>> @@ -410,8 +410,10 @@ public class JUnitSampler extends Abstra >>>>>>> tr.addFailure(theClazz, afe); >>>>>>> } else if (cause != null) { >>>>>>> tr.addError(theClazz, cause); >>>>>>> + log.warn("caught exception", e); >>>>>>> } else { >>>>>>> tr.addError(theClazz, e); >>>>>>> + log.warn("caught exception", e); >>>>>>> } >>>>>>> } catch (IllegalAccessException | >>>>>>> IllegalArgumentException e) >>>>>>> { >>>>>>> tr.addError(theClazz, e); >>>>>>> >>>>>>> Modified: jmeter/trunk/xdocs/changes.xml >>>>>>> URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes. >>>>>>> xml?rev=1824355&r1=1824354&r2=1824355&view=diff >>>>>>> ============================================================ >>>>>>> ================== >>>>>>> --- jmeter/trunk/xdocs/changes.xml [utf-8] (original) >>>>>>> +++ jmeter/trunk/xdocs/changes.xml [utf-8] Thu Feb 15 20:09:16 2018 >>>>>>> @@ -86,6 +86,7 @@ Summary >>>>>>> >>>>>>> <h3>Other samplers</h3> >>>>>>> <ul> >>>>>>> + <li><pr>376</pr>JUnitSampler logs exceptions except assertion- >>>>>>> failures >>>>>>> from test cases as warnings. Contributed by Davide Angelocola >>>>>>> (davide.angelocola at fisglobal.com)</li> >>>>>>> </ul> >>>>>>> >>>>>>> <h3>Controllers</h3> >>>>>>> @@ -174,6 +175,7 @@ Summary >>>>>>> <ul> >>>>>>> <li>Graham Russell (graham at ham1.co.uk)</li> >>>>>>> <li>orimarko at gmail.com</li> >>>>>>> + <li>Davide Angelocola (davide.angelocola at >>>>>>> fisglobal.com)</li> >>>>>>> </ul> >>>>>>> <p>We also thank bug reporters who helped us improve JMeter.</p> >>>>>>> <p> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> > -- Cordialement. Philippe Mouawad.
