GitHub user FSchumacher opened a pull request:
https://github.com/apache/jmeter/pull/409
Cleanup saveservice
## Description
Cleanup code in `SaveService`.
## Motivation and Context
I always like to look at the warnings in the IDE to see, where the code has
problems. If there are too many warnings, I tend to oversee the real dangerous
ones. So this pull request tries to get rid of the ones that are easy to fix
and hopefully clearer to read.
## How Has This Been Tested?
Ran the unit tests.
## Screenshots (if appropriate):
## Types of changes
- Code cleanup / refactoring
## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
- [x] My code follows the [code style][style-guide] of this project.
[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/FSchumacher/jmeter cleanup-saveservice
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/409.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #409
----
commit 7bfc83f90d7dd0ed3f279e83b77a1470c6ff6b97
Author: Felix Schumacher <felix.schumacher@...>
Date: 2018-10-14T11:00:50Z
Clarify that we want a single class constructor.
commit dc4b0746b46e8c30bfecd72dd695837cdb83c7c3
Author: Felix Schumacher <felix.schumacher@...>
Date: 2018-10-14T11:05:18Z
Refactor nested try block to named function
commit bba5780e04614c923f78511aad4098b6e320d681
Author: Felix Schumacher <felix.schumacher@...>
Date: 2018-10-14T11:09:22Z
Reduce duplicated code by using a variable
commit 54476f922d17b46cf3ec5f9dc57db5fd543df659
Author: Felix Schumacher <felix.schumacher@...>
Date: 2018-10-14T11:10:10Z
Use correct order of keywords as specified in JLS
commit 6ae11df28b77b6655c4af8b340273d91f5413eef
Author: Felix Schumacher <felix.schumacher@...>
Date: 2018-10-14T11:11:55Z
Return result directly.
----
---
