Github user FSchumacher commented on a diff in the pull request:

    https://github.com/apache/jmeter/pull/432#discussion_r235119001
  
    --- Diff: src/core/org/apache/jmeter/gui/action/SelectTemplatesDialog.java 
---
    @@ -207,19 +290,35 @@ private void init() { // WARNING: called from ctor so 
must not be overridden (i.
         public void actionPerformed(ActionEvent e) {
             final Object source = e.getSource();
             if (source == cancelButton) {
    -            this.setVisible(false);
    -            return;
    +            resetJDialog();
    +            this.dispose();
             } else if (source == applyTemplateButton) {
    -            checkDirtyAndLoad(e);            
    -        } else if (source == reloadTemplateButton) {
    -            
templateList.setValues(TemplateManager.getInstance().reset().getTemplateNames());
    +            String selectedTemplate = templateList.getText();
    +            Template template = 
TemplateManager.getInstance().getTemplateByName(selectedTemplate);
    +            if(template.getParameters() != null && 
!template.getParameters().isEmpty()) {
    +                
this.setContentPane(configureParametersPanel(template.getParameters()));
    +                this.revalidate();
    +            }else {
    +                checkDirtyAndLoad(e);
    +            }
    +        } else if (source == reloadTemplateButton || source == previous) {
    +            resetJDialog();
    +        } else if(source == validateButton) {
    --- End diff --
    
    Same as with `for`. Spacepolice is calling :)


---

Reply via email to