Hi All,

I have created a PR https://github.com/apache/jmeter/pull/440  .

I have made some changes in the following file and I want to cover my code with 
Junit coverage.

File name: HTTPHC4Impl.java
Method name: createUrlEncodedFormEntity (line no: 1691-1700)

Moreover, After analyzing the code I found that this method is being covered by 
tests written in TestHTTPSamplersAgainstHttpMirrorServer.java class file.

Some added code have been covered by existing tests, However I could not cover 
the catch block code as when I pass the wrong encoding to throw exception so 
that catch block can handle the same. But in this case JVM is terminated and 
execution process gets stopped.

Do anyone have idea how can I cover my catch block code.

One more thing I would like to ask:

While creating PR, is it necessary to cover all code changes or Its an optional.


Thanks and Regards,
Sanjay Chaurasia

Reply via email to