sebb> to prove the Gradle build.

Sebb, please note I'm not going to prove anything.
I'm just going to replace current Ant build with a Gradle-based build.

Apparently, Gradle provides much better developer experience, so it
has passed the point of "proof of concept".
There are routine steps to complete, however it has past the point
when we are not sure if Gradle would get hairy to support JMeter
project.

sebb> But this needs to be repeatable by others.

Go ahead, check out the branch and perform `./gradlew check createDist`

sebb> We would not accept a patch that introduced new code and also changed
sebb> large amounts of indentation and space trimming at the same time.

Did I change large amounts of indentation and space trimming?
I don't think so.

What you say is true, however I don't really see how it applies to my change.

Sebb, my steps are repeatable by others (e.g. by Travis), and I don
not change indentation nor space trimming.
So far, my change does not have flaws you describe.

sebb>Then please do so.

It makes no sense as I said earlier.
So far you have not provided a technical reason for keeping layout.

I agree "moving code" is not very pleasing, however I do have
technical reasons for doing so, and I'm sure the benefits would
greatly outweigh aesthetic feelings.

Vladimir

Reply via email to