Hi,

TL;DR:  what if we copy Darcula sources into JMeter repository and fix it a
bit?
At the end of the day, Darcula is AL2.

+1: Of course, let's copy it, and drop when upstream publishes a new release
+0.5: Ok, let's copy it. And drop when upstream publishes a new release
0: JMeter UX is perfect
-0: ?! Copy-paste development is forbidden
-1: Do not do that because ...


I've got a report that Darcula theme makes it hard to understand the
component tree.
The user seems to like the dark theme, however, the UX is bad, so they
revert to the classic one.
The issue is nesting is barely visible because of the very small offset in
the tree.

A sample screenshot:
https://jmeter.apache.org/images/screenshots/changes/5.0/jmeter_5_search_feature.png

The items "RA_Redirected" and "HR_NoAutoRedirect" look as if they are
placed under the same parent.
Remember that the picture represents a very basic test plan, and for more
involved cases it would be extremely confusing.

It seems to be a regression when compared with the old theme:
https://jmeter.apache.org/images/screenshots/http-config/http-config-example.png

We ship with Darcula by default, so it is sad to have a bad-looking tree
there.

I've tracked the issue, and the offset is hard-coded in Darcula repository:
https://github.com/bulenkov/Darcula/blob/49774425c392c36d926b8a4518a3616a8cf735e2/src/com/bulenkov/darcula/ui/DarculaTreeUI.java#L60

However, the author says he won't fix current Darcula, as "the upstream"
(==Darcula that is present in IntelliJ sources) is way ahead.
In other words, the author suggests he (or somebody else, because, well, it
is OSS) would factor out "IntelliJ Darcula" into its own submodule, then he
could grab it and publish it as a separate artifact.
See https://github.com/bulenkov/Darcula/issues/56#issuecomment-526942616
However, I don't think it would happen soon taking the number of Darcula
releases into account (1 release per 6 years).


Vladimir

Reply via email to