> However JUnit migration is huge, and it does require review. It is wrong that the new test code reuses test file names across different tests. That breaks parallel execution, and it might easily create test failures when the result of one test impacts another.
For instance, the commit https://github.com/apache/jmeter/pull/524/commits/4f185ae39128317d75ff9ad5e2c138fffc91c8ab moves from "different file for each test" to "the same file for each test" style. The PR contains "unrelated" questionable changes like the one to TestKeyToolUtils#setup. The test was already written in JUnit5, and it is not clear why the PR changed that method. It is not the full list, however, I suggest we do not hurry in merging the changes to the codebase. Vladimir
