Ok by me if you want to change it On Tue, Nov 24, 2020 at 3:57 PM Felix Schumacher < felix.schumac...@internetallee.de> wrote:
> > Am 24.11.20 um 15:50 schrieb pmoua...@apache.org: > > This is an automated email from the ASF dual-hosted git repository. > > > > pmouawad pushed a commit to branch master > > in repository https://gitbox.apache.org/repos/asf/jmeter.git > > > > > > The following commit(s) were added to refs/heads/master by this push: > > new 88be852 Bug 64935 - A broken plugin class should not prevent > JMeter from starting > > 88be852 is described below > > > > commit 88be852762cd5db86ecd7d8b035549a9782a5cb9 > > Author: pmouawad <p.moua...@ubik-ingenierie.com> > > AuthorDate: Tue Nov 24 15:49:49 2020 +0100 > > > > Bug 64935 - A broken plugin class should not prevent JMeter from > > starting > > --- > > .../src/main/java/org/apache/jmeter/gui/util/JMeterMenuBar.java | 6 > +++++- > > xdocs/changes.xml | 1 > + > > 2 files changed, 6 insertions(+), 1 deletion(-) > > > > diff --git > a/src/core/src/main/java/org/apache/jmeter/gui/util/JMeterMenuBar.java > b/src/core/src/main/java/org/apache/jmeter/gui/util/JMeterMenuBar.java > > index f05d262..0091776 100644 > > --- > a/src/core/src/main/java/org/apache/jmeter/gui/util/JMeterMenuBar.java > > +++ > b/src/core/src/main/java/org/apache/jmeter/gui/util/JMeterMenuBar.java > > @@ -232,8 +232,12 @@ public class JMeterMenuBar extends JMenuBar > implements LocaleChangeListener { > > MenuCreator creator = (MenuCreator) > commandClass.getDeclaredConstructor().newInstance(); > > creators.add(creator); > > } > > + } catch (NoClassDefFoundError e) { > > + log.error("Exception registering implementation:{} > of interface:{}, a dependency used by the plugin class is missing", > > + strClassName, MenuCreator.class, e); > > } catch (Exception e) { > > - log.error("Exception registering {} with > implementation: {}", MenuCreator.class, strClassName, e); > > + log.error("Exception registering implementation > {} of interface:{}, a jar is probably missing", > > + strClassName, MenuCreator.class, e); > > Should we really take a guess at the reason for the Exception? > > The messages are almost identical, except that the first has no spaces > between the colon and the placeholders and the second one has one space > instead of the colon (plus the guessed reasons). I think we should add a > space after the colons and we might add parenthesis around the > placeholders: ... implementation: [{}] of ... > > (Will do so in a moment ;)) > > Felix > > > } > > } > > } catch (IOException e) { > > diff --git a/xdocs/changes.xml b/xdocs/changes.xml > > index 05381dc..5ba3735 100644 > > --- a/xdocs/changes.xml > > +++ b/xdocs/changes.xml > > @@ -227,6 +227,7 @@ applications when JMeter is starting up.</p> > > <li><bug>64453</bug>Darklaf: Save Test Plan as New Folder > failure</li> > > <li><bug>64625</bug>Darklaf: trying to select a folder in Browse > leads to an error popup and stacktrace</li> > > <li><bug>64711</bug>Textarea Colors are not good in dark modes. > Contributed by Jannis Weis</li> > > + <li><bug>64935</bug>A broken plugin class should not prevent JMeter > from starting</li> > > </ul> > > > > <!-- =================== Thanks =================== --> > > > -- Cordialement. Philippe Mouawad.
