mjmadhu opened a new pull request #640:
URL: https://github.com/apache/jmeter/pull/640


   ## Description
   Support to http.socket.timeout through properties
     - read httpclient parameters from hc.parameters.file if provided in 
jmeter.properties
     - set http socket timeout for HTTP Sampler in the following preference 
order:
         *  1. Response timeout in HTTP Sampler/ HTTP Request Defaults
         *  2. http.socket.timeout in hc.parameters
         *  3. httpclient.timeout property in jmeter.properties
   
   ## Motivation and Context
     - JMeter tests were not stopping in distributed mode in our system. We got 
thread dumps and found forever hanging HTTP request threads to be the main 
cause for the issue. Since we're not the author of the test plans, we can't 
assure timeouts to be always configured in test plan. Hence, we require some 
jmeter properties to control this behavior, only to find they were not working 
as expected.
     - Logged the following bug: 
https://bz.apache.org/bugzilla/show_bug.cgi?id=65041
   
   ## How Has This Been Tested?
    - Added JUnit tests and verified them to be passed.
    - Verified JMeter to be built and working fine.
   
   ## Types of changes
   - Bug fix (non-breaking change which fixes an issue)
   - New feature (non-breaking change which adds functionality)
   
   ## Checklist:
   - [ x ] My code follows the [code style][style-guide] of this project.
   - [  ] I have updated the documentation accordingly.
   
   [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to