woonsan commented on a change in pull request #651:
URL: https://github.com/apache/jmeter/pull/651#discussion_r594006487
##########
File path:
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/util/GraphQLRequestParamUtils.java
##########
@@ -79,27 +76,32 @@ public static boolean isGraphQLContentType(final String
contentType) {
* @throws RuntimeException if JSON serialization fails for some reason
due to any runtime environment issues
*/
public static String toPostBodyString(final GraphQLRequestParams params) {
- final ObjectMapper mapper = new ObjectMapper();
- final ObjectNode postBodyJson = mapper.createObjectNode();
- postBodyJson.set(OPERATION_NAME_FIELD,
-
JsonNodeFactory.instance.textNode(StringUtils.trimToNull(params.getOperationName())));
-
+ final StringBuilder result = new StringBuilder();
Review comment:
Thanks, @FSchumacher and @vlsi !
I didn't think about the variables in the http params to be resolved in
samplings at the moment. Now I understand the problem from your insightful
discussions above.
As @FSchumacher mentioned, it sounds like simpler with overriding with a
wrapper, after variables are resolved _somehow_, if possible.
Regards, woonsan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
