rithvikp1998 opened a new pull request #671:
URL: https://github.com/apache/jmeter/pull/671
## Description
PercentileAggregator class reads the value for statistic_window using the
following line:
```
private static final int SLIDING_WINDOW_SIZE = JMeterUtils.getPropDefault(
ReportGeneratorConfiguration.REPORT_GENERATOR_KEY_PREFIX
+ ReportGeneratorConfiguration.KEY_DELIMITER
+ "statistic_window", 20000);
```
getPropDefault() calls appProperties.getProperty(). But in the appProperties
we are only loading jmeter.properties, user.properties, system.properties etc
and _not_ reportgenerator.properties where the value for statistic_window is
supposed to be set. So the default value of 20,000 is being picked irrespective
of what is set in the properties file.
_There are multiple ways to fix this issue but I chose this approach because
it is the least intrusive._
## Motivation and Context
https://bz.apache.org/bugzilla/show_bug.cgi?id=65446
## How Has This Been Tested?
I built the code with the new changes and generated dashboards with some
debug log statements in the code. The dashboards were getting generated
correctly and the log statements are printing whatever property value I am
setting. (Without this patch, they always print 20,000 as the size of the
statistic window even when I am setting a different value in
reportgenerator.properties file)
## Screenshots (if appropriate):
## Types of changes
<!--- What types of changes does your code introduce? Delete as appropriate
-->
- Bug fix (non-breaking change which fixes an issue)
## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that
apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] My code follows the [code style][style-guide] of this project.
- [ ] I have updated the documentation accordingly.
[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
