I understand that Kotlin is better for DSL, so I would suggest to restrict Kotlin use to this part only unless there is a blocker in Java.
On Fri, Nov 5, 2021 at 12:24 AM Philippe Mouawad <[email protected]> wrote: > Hello Vladimir, > > Thanks for the PR and work on it. > > I started looking at code, and I am wondering if there is a particular > reason for not using Java for the new development ? > I must say I am not comfortable with mixing Java and Kotlin in the project. > I have reduced my activity on project these last month, so my opinion does > not count as much as a more active contributor as Felix. > > But if I was as active as I have been in the past (I may be more active in > the future), I would tend to stick to Java unless Kotlin brings something > that is not available in Java. > In the past, there was this PR https://github.com/apache/jmeter/pull/540 > which was using Kotlin for a good reason I think. > In this particular case , I don't see it. > > Regards > Philippe > > > On Tue, Nov 2, 2021 at 9:58 PM Antonio Gomes Rodrigues <[email protected]> > wrote: > >> Hi Vladimir, >> >> It looks good, I will test it asap >> >> Do you plan to add a feature to load/save events fired time (seed) to have >> exactly the same repeatable sequence for each test execution? >> >> Le dim. 31 oct. 2021 à 21:01, Vladimir Sitnikov < >> [email protected]> >> a écrit : >> >> > I wanted to add a chart with "desired load profile", and I found >> > https://github.com/JetBrains/lets-plot charting library. >> > The screenshot is in the PR >> > >> > It adds some jars to the distribution, however, I think it would be >> hard to >> > find another library. >> > The unfortunate consequence is that UI dependencies become "core" >> > dependencies. I've no idea what to do with that, >> > and we might probably want to move UI classes to core-ui module or >> > something like that. >> > >> > The current dependency diff is as follows: >> > >> > 54852334 => 71166807 bytes (+16314473 bytes) >> > 99 => 134 files (+35) >> > >> > + 17536 annotations-13.0.jar >> > - 18538 annotations-16.0.2.jar >> > + 507197 base-portable-jvm-2.1.0.jar >> > + 485809 batik-anim-1.14.jar >> > + 424624 batik-awt-util-1.14.jar >> > + 703757 batik-bridge-1.14.jar >> > + 112373 batik-codec-1.14.jar >> > + 8433 batik-constants-1.14.jar >> > + 330318 batik-css-1.14.jar >> > + 184487 batik-dom-1.14.jar >> > + 10238 batik-ext-1.14.jar >> > + 192087 batik-gvt-1.14.jar >> > + 11466 batik-i18n-1.14.jar >> > + 76875 batik-parser-1.14.jar >> > + 25876 batik-script-1.14.jar >> > + 6663 batik-shared-resources-1.14.jar >> > + 232734 batik-svg-dom-1.14.jar >> > + 227514 batik-svggen-1.14.jar >> > + 129300 batik-transcoder-1.14.jar >> > + 127477 batik-util-1.14.jar >> > + 33866 batik-xml-1.14.jar >> > + 32033 kotlin-logging-jvm-2.0.5.jar >> > + 2993765 kotlin-reflect-1.5.21.jar >> > + 1505952 kotlin-stdlib-1.5.31.jar >> > + 198322 kotlin-stdlib-common-1.5.31.jar >> > + 22986 kotlin-stdlib-jdk7-1.5.31.jar >> > + 16121 kotlin-stdlib-jdk8-1.5.31.jar >> > + 792176 kotlinx-html-jvm-0.7.3.jar >> > + 196707 lets-plot-batik-2.1.0.jar >> > + 3593892 lets-plot-common-2.1.0.jar >> > + 627895 plot-api-jvm-3.0.2.jar >> > + 882509 plot-base-portable-jvm-2.1.0.jar >> > + 792534 plot-builder-portable-jvm-2.1.0.jar >> > + 115007 plot-common-portable-jvm-2.1.0.jar >> > + 454864 plot-config-portable-jvm-2.1.0.jar >> > + 173932 vis-svg-portable-jvm-2.1.0.jar >> > + 85686 xml-apis-ext-1.3.04.jar >> > >> > Vladimir >> > >> > > > -- > Cordialement. > Philippe Mouawad. > > > -- Cordialement. Philippe Mouawad.
