vlsi commented on a change in pull request #660:
URL: https://github.com/apache/jmeter/pull/660#discussion_r750060872
##########
File path:
src/protocol/http/src/test/java/org/apache/jmeter/protocol/http/util/TestGraphQLRequestParamUtils.java
##########
@@ -99,7 +103,15 @@ void testInvalidGraphQLContentType(String contentType) {
@Test
void testToPostBodyString() throws Exception {
- assertEquals(EXPECTED_POST_BODY,
GraphQLRequestParamUtils.toPostBodyString(params));
+ final JsonNode expectedPostBodyJson =
objectMapper.readTree(EXPECTED_POST_BODY);
+ final JsonNode actualPostBodyJson =
objectMapper.readTree(GraphQLRequestParamUtils.toPostBodyString(params));
+
+
assertEquals(expectedPostBodyJson.get(GraphQLRequestParamUtils.OPERATION_NAME_FIELD),
+
actualPostBodyJson.get(GraphQLRequestParamUtils.OPERATION_NAME_FIELD));
Review comment:
An alternative option is to use `@ParameterizedTest`, however, please
include `field name` and `input data` into the assertion message in any case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
