vlsi commented on a change in pull request #640:
URL: https://github.com/apache/jmeter/pull/640#discussion_r778701704
##########
File path:
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/sampler/HTTPHCAbstractImpl.java
##########
@@ -107,8 +110,13 @@
static {
if(!StringUtils.isEmpty(JMeterUtils.getProperty("httpclient.timeout"))) {
//$NON-NLS-1$
log.warn("You're using property 'httpclient.timeout' that will
soon be deprecated for HttpClient3.1, you should either set "
- + "timeout in HTTP Request GUI, HTTP Request Defaults or
set http.socket.timeout in httpclient.parameters");
+ + "timeout in HTTP Request GUI, HTTP Request Defaults or
set http.socket.timeout in hc.parameters");
+ }
+
+
if(!StringUtils.isEmpty(JMeterUtils.getProperty("hc.parameters.file"))) {
//$NON-NLS-1$
+
HttpClientDefaultParameters.load(JMeterUtils.getProperty("hc.parameters.file"),
HTTPCLIENT_PARAMS);
Review comment:
It looks like the file will be loaded only once. I suggest the file
should be loaded at the start of the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
