vlsi opened a new pull request, #712:
URL: https://github.com/apache/jmeter/pull/712

   ## Description
   
   This PR moves `startGui` from `class JMeter` to another class.
   
   ## Motivation and Context
   
   a) It is nice to factor UI from non-UI code
   b) Current code fails to update progress during "GUI startup". The reason is 
that all the contents of `startGui` is running in a single `Runnable`, so Swing 
has no way to break in-between and render progress updates.
   See https://bz.apache.org/bugzilla/show_bug.cgi?id=66044#c5
   
   Coroutines enable an easy-to-maintain approach for splitting long UI methods 
into chunks.
   In this case, I used `yield()` right after `setProgress`, so we give room 
for the Swing event dispatcher thread to update the UI.
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that 
apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here 
to help! -->
   - [x] My code follows the [code style][style-guide] of this project.
   - [ ] I have updated the documentation accordingly.
   
   [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to