vlsi commented on code in PR #711: URL: https://github.com/apache/jmeter/pull/711#discussion_r868368164
########## xdocs/usermanual/get-started.xml: ########## @@ -279,7 +279,7 @@ jmeter -t test.jmx … <dl> <dt><code>DDRAW</code></dt><dd>JVM options to influence usage of direct draw, e.g. <code>-Dsun.java2d.ddscale=true</code>. Default is empty.</dd> <dt><code>GC_ALGO</code></dt><dd>JVM garbage collector options. Defaults to <code>-XX:+UseG1GC -XX:MaxGCPauseMillis=250 -XX:G1ReservePercent=20</code></dd> -<dt><code>HEAP</code></dt><dd>JVM memory settings used when starting JMeter. Defaults to <code>-Xms1g -Xmx1g -XX:MaxMetaspaceSize=256m</code></dd> +<dt><code>HEAP</code></dt><dd>JVM memory settings used when starting JMeter. Defaults to <code>-Xms1g -Xmx1g -X:MaxMetaspaceSize=256m</code></dd> Review Comment: Could you please clarify the reason for the chnage? AFAIK, `-XX:MaxMetaspaceSize=256m` is the proper syntax -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
