vlsi commented on code in PR #719:
URL: https://github.com/apache/jmeter/pull/719#discussion_r913883223
##########
src/core/src/main/java/org/apache/jmeter/gui/action/LookAndFeelCommand.java:
##########
@@ -200,7 +200,7 @@ public LookAndFeelCommand() {
}
public static boolean isDarklafTheme() {
- return "Darklaf".equals(UIManager.getLookAndFeel().getID()); //
$NON-NLS-1$
+ return "Darklaf".equalsIgnoreCase(UIManager.getLookAndFeel().getID());
// $NON-NLS-1$
Review Comment:
Wow. This is unexpected. I wonder if we could eliminate `isDarklafTheme()`
altogether. It is really surprising that `isDarklafTheme()` impacts colors.
##########
src/core/src/main/java/org/apache/jmeter/gui/action/LookAndFeelCommand.java:
##########
@@ -200,7 +200,7 @@ public LookAndFeelCommand() {
}
public static boolean isDarklafTheme() {
- return "Darklaf".equals(UIManager.getLookAndFeel().getID()); //
$NON-NLS-1$
+ return "Darklaf".equalsIgnoreCase(UIManager.getLookAndFeel().getID());
// $NON-NLS-1$
Review Comment:
Wow. This is unexpected for me. I wonder if we could eliminate
`isDarklafTheme()` altogether. It is really surprising that `isDarklafTheme()`
impacts colors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
